Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1580063

Re: [PATCH v2 3/9] sysctl: add unsigned int range support

From Kees Cook <keescook@chromium.org>
Newsgroups linux.kernel
Subject Re: [PATCH v2 3/9] sysctl: add unsigned int range support
Date 2017-02-13 21:30 +0100
Message-ID <tavq2-6i-29@gated-at.bofh.it> (permalink)
References <t8LSh-7Ue-11@gated-at.bofh.it> <t9tTj-29U-3@gated-at.bofh.it> <t9tTk-29U-31@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Fri, Feb 10, 2017 at 4:36 PM, Luis R. Rodriguez <mcgrof@kernel.org> wrote:
> To keep parity with regular int interfaces provide the an unsigned
> int proc_douintvec_minmax() which allows you to specify a range of
> allowed valid numbers.
>
> Adding proc_douintvec_minmax_sysadmin() is easy but we can wait for
> an actual user for that.
>
> Cc: Subash Abhinov Kasiviswanathan <subashab@codeaurora.org>
> Cc: Heinrich Schuchardt <xypron.glpk@gmx.de>
> Cc: Kees Cook <keescook@chromium.org>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Linus Torvalds <torvalds@linux-foundation.org>
> Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org>

Acked-by: Kees Cook <keescook@chromium.org>

This looks sensible. :)

-Kees

-- 
Kees Cook
Pixel Security

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [PATCH] sysctl: add proper unsigned int support "Luis R. Rodriguez" <mcgrof@kernel.org> - 2017-02-01 21:00 +0100
  Re: [PATCH] sysctl: add proper unsigned int support "Luis R. Rodriguez" <mcgrof@kernel.org> - 2017-02-09 02:40 +0100
  Re: [PATCH] sysctl: add proper unsigned int support "Luis R. Rodriguez" <mcgrof@kernel.org> - 2017-02-09 02:50 +0100
    [PATCH v2 5/9] test_sysctl: add generic script to expand on tests "Luis R. Rodriguez" <mcgrof@kernel.org> - 2017-02-11 01:40 +0100
      Re: [PATCH v2 5/9] test_sysctl: add generic script to expand on tests Kees Cook <keescook@chromium.org> - 2017-02-13 21:40 +0100
    [PATCH v2 9/9] test_sysctl: test against int proc_dointvec() array support "Luis R. Rodriguez" <mcgrof@kernel.org> - 2017-02-11 01:40 +0100
      Re: [PATCH v2 9/9] test_sysctl: test against int proc_dointvec()  array support Kees Cook <keescook@chromium.org> - 2017-02-13 23:10 +0100
    [PATCH v2 4/9] test_sysctl: add dedicated proc sysctl test driver "Luis R. Rodriguez" <mcgrof@kernel.org> - 2017-02-11 01:40 +0100
      Re: [PATCH v2 4/9] test_sysctl: add dedicated proc sysctl test driver Kees Cook <keescook@chromium.org> - 2017-02-13 21:30 +0100
    [PATCH v2 6/9] test_sysctl: test against PAGE_SIZE for int "Luis R. Rodriguez" <mcgrof@kernel.org> - 2017-02-11 01:40 +0100
    [PATCH v2 1/9] sysctl: fix lax sysctl_check_table() sanity check "Luis R. Rodriguez" <mcgrof@kernel.org> - 2017-02-11 01:40 +0100
      Re: [PATCH v2 1/9] sysctl: fix lax sysctl_check_table() sanity check Kees Cook <keescook@chromium.org> - 2017-02-13 21:20 +0100
    [PATCH v2 2/9] sysctl: add proper unsigned int support "Luis R. Rodriguez" <mcgrof@kernel.org> - 2017-02-11 01:40 +0100
      Re: [PATCH v2 2/9] sysctl: add proper unsigned int support Kees Cook <keescook@chromium.org> - 2017-02-13 21:30 +0100
    [PATCH v2 3/9] sysctl: add unsigned int range support "Luis R. Rodriguez" <mcgrof@kernel.org> - 2017-02-11 01:40 +0100
      Re: [PATCH v2 3/9] sysctl: add unsigned int range support Kees Cook <keescook@chromium.org> - 2017-02-13 21:30 +0100
    [PATCH v2 7/9] test_sysctl: add simple proc_dointvec() case "Luis R. Rodriguez" <mcgrof@kernel.org> - 2017-02-11 01:40 +0100
      Re: [PATCH v2 7/9] test_sysctl: add simple proc_dointvec() case Kees Cook <keescook@chromium.org> - 2017-02-13 23:10 +0100
    [PATCH v2 0/9] sysctl: add and fix proper unsigned int support "Luis R. Rodriguez" <mcgrof@kernel.org> - 2017-02-11 01:40 +0100
      [PATCH v2 8/9] test_sysctl: add simple proc_douintvec() case "Luis R. Rodriguez" <mcgrof@kernel.org> - 2017-02-11 01:40 +0100
      Re: [PATCH v2 0/9] sysctl: add and fix proper unsigned int support Kees Cook <keescook@chromium.org> - 2017-02-13 21:20 +0100

csiph-web