Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1580725
| From | Greg KH <gregkh@linuxfoundation.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] staging: fwserial: replace 'a' with '(a)' to avoid precedence issues |
| Date | 2017-02-14 19:10 +0100 |
| Message-ID | <taPI5-5ax-15@gated-at.bofh.it> (permalink) |
| References | <taPyp-4RU-11@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tue, Feb 14, 2017 at 11:26:20PM +0530, Arushi Singhal wrote:
> Macro argument 'a' may be better as '(a)' to avoid precedence issues as
> reported by checkpatch.pl
>
> Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
> ---
> drivers/staging/fwserial/fwserial.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/fwserial/fwserial.c b/drivers/staging/fwserial/fwserial.c
> index 41a49c8194e5..bdfc0a8c7af3 100644
> --- a/drivers/staging/fwserial/fwserial.c
> +++ b/drivers/staging/fwserial/fwserial.c
> @@ -98,7 +98,7 @@ struct fwtty_transaction {
> };
> };
>
> -#define to_device(a, b) (a->b)
> +#define to_device((a), b) (a->b)
Really? Why do we even have this macro at all? Can it just be removed?
thanks,
greg k-h
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] staging: fwserial: replace 'a' with '(a)' to avoid precedence issues Arushi Singhal <arushisinghal19971997@gmail.com> - 2017-02-14 19:00 +0100
Re: [PATCH] staging: fwserial: replace 'a' with '(a)' to avoid precedence issues Greg KH <gregkh@linuxfoundation.org> - 2017-02-14 19:10 +0100
Re: [PATCH] staging: fwserial: replace 'a' with '(a)' to avoid precedence issues Geert Uytterhoeven <geert@linux-m68k.org> - 2017-02-15 09:20 +0100
Re: [PATCH] staging: fwserial: replace 'a' with '(a)' to avoid precedence issues Joe Perches <joe@perches.com> - 2017-02-15 10:40 +0100
csiph-web