Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1674599

[PATCH 17/20] lightnvm: pblk: add lock assertions on helpers

Show all headers | View raw

Add lockdep assertions on helper functions.

Signed-off-by: Javier González <javier@cnexlabs.com>
Signed-off-by: Matias Bjørling <matias@cnexlabs.com>
---
 drivers/lightnvm/pblk-core.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/lightnvm/pblk-core.c b/drivers/lightnvm/pblk-core.c
index d815cdad56b8..ed41cd7700b3 100644
--- a/drivers/lightnvm/pblk-core.c
+++ b/drivers/lightnvm/pblk-core.c
@@ -295,6 +295,8 @@ struct list_head *pblk_line_gc_list(struct pblk *pblk, struct pblk_line *line)
 	struct list_head *move_list = NULL;
 	int vsc = le32_to_cpu(*line->vsc);
 
+	lockdep_assert_held(&line->lock);
+
 	if (!vsc) {
 		if (line->gc_group != PBLK_LINEGC_FULL) {
 			line->gc_group = PBLK_LINEGC_FULL;
@@ -502,6 +504,8 @@ u64 __pblk_alloc_page(struct pblk *pblk, struct pblk_line *line, int nr_secs)
 	u64 addr;
 	int i;
 
+	lockdep_assert_held(&line->lock);
+
 	/* logic error: ppa out-of-bounds. Prevent generating bad address */
 	if (line->cur_sec + nr_secs > pblk->lm.sec_per_line) {
 		WARN(1, "pblk: page allocation out of bounds\n");
-- 
2.7.4

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 00/20] LightNVM: pblk patches for 4.13 "Javier González" <jg@lightnvm.io> - 2017-06-26 12:00 +0200
  [PATCH 04/20] lightnvm: pblk: add debug stat for read cache hits "Javier González" <jg@lightnvm.io> - 2017-06-26 12:00 +0200
  [PATCH 02/20] lightnvm: propagate right error code to target "Javier González" <jg@lightnvm.io> - 2017-06-26 12:00 +0200
  [PATCH 14/20] lightnvm: pblk: choose optimal victim GC line "Javier González" <jg@lightnvm.io> - 2017-06-26 12:10 +0200
  [PATCH 17/20] lightnvm: pblk: add lock assertions on helpers "Javier González" <jg@lightnvm.io> - 2017-06-26 12:10 +0200
  [PATCH 15/20] lightnvm: pblk: set metadata list for all I/Os "Javier González" <jg@lightnvm.io> - 2017-06-26 12:10 +0200
  [PATCH 01/20] lightnvm: re-convert ppa format on I/O failure "Javier González" <jg@lightnvm.io> - 2017-06-26 12:10 +0200
  [PATCH 13/20] lightnvm: pblk: decouple bad block from line alloc "Javier González" <jg@lightnvm.io> - 2017-06-26 12:10 +0200
  [PATCH 11/20] lightnvm: pblk: issue multiplane reads if possible "Javier González" <jg@lightnvm.io> - 2017-06-26 12:10 +0200
  [PATCH 06/20] lightnvm: pblk: generalize erase path "Javier González" <jg@lightnvm.io> - 2017-06-26 12:10 +0200
  [PATCH 19/20] lightnvm: pblk: set mempool and workqueue params. "Javier González" <jg@lightnvm.io> - 2017-06-26 12:10 +0200
  [PATCH 16/20] lightnvm: pblk: cleanup unnecessary code "Javier González" <jg@lightnvm.io> - 2017-06-26 12:10 +0200
  [PATCH 18/20] lightnvm: pblk: redesign GC algorithm "Javier González" <jg@lightnvm.io> - 2017-06-26 12:10 +0200
  [PATCH 12/20] lightnvm: pblk: simplify meta. memory allocation "Javier González" <jg@lightnvm.io> - 2017-06-26 12:10 +0200
  [PATCH 20/20] lightnvm: pblk: fail gracefully on irrec. error "Javier González" <jg@lightnvm.io> - 2017-06-26 12:10 +0200
  Re: [PATCH 00/20] LightNVM: pblk patches for 4.13 Jens Axboe <axboe@kernel.dk> - 2017-06-27 00:30 +0200
    Re: [PATCH 00/20] LightNVM: pblk patches for 4.13 Javier González <jg@lightnvm.io> - 2017-06-27 10:10 +0200

csiph-web