Re: [RFC PATCH] mm, oom: allow oom reaper to race with exit_mmap

From	Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH] mm, oom: allow oom reaper to race with exit_mmap
Date	2017-06-27 15:40 +0200
Message-ID	<tWYSL-18m-33@gated-at.bofh.it> (permalink)
References	<tWBWa-2LF-9@gated-at.bofh.it> <tWWnU-7LB-3@gated-at.bofh.it> <tWWQW-8f0-21@gated-at.bofh.it> <tWX0B-8iz-19@gated-at.bofh.it> <tWXtD-hF-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Michal Hocko wrote:
> On Tue 27-06-17 20:39:28, Tetsuo Handa wrote:
> > Michal Hocko wrote:
> > > > I wonder why you prefer timeout based approach. Your patch will after all
> > > > set MMF_OOM_SKIP if operations between down_write() and up_write() took
> > > > more than one second.
> > > 
> > > if we reach down_write then we have unmapped the address space in
> > > exit_mmap and oom reaper cannot do much more.
> > 
> > So, by the time down_write() is called, majority of memory is already released, isn't it?
> 
> In most cases yes. To be put it in other words. By the time exit_mmap
> takes down_write there is nothing more oom reaper could reclaim.
> 
Then, aren't there two exceptions which your patch cannot guarantee;
down_write(&mm->mmap_sem) in __ksm_exit() and __khugepaged_exit() ?

Since for some reason exit_mmap() cannot be brought to before
ksm_exit(mm)/khugepaged_exit(mm) calls,

	ksm_exit(mm);
	khugepaged_exit(mm); /* must run before exit_mmap */
	exit_mmap(mm);

shouldn't we try __oom_reap_task_mm() before calling these down_write()
if mm is OOM victim's?

Thread

[RFC PATCH] mm, oom: allow oom reaper to race with exit_mmap Michal Hocko <mhocko@kernel.org> - 2017-06-26 15:10 +0200
  Re: [RFC PATCH] mm, oom: allow oom reaper to race with exit_mmap Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> - 2017-06-27 13:00 +0200
    Re: [RFC PATCH] mm, oom: allow oom reaper to race with exit_mmap Michal Hocko <mhocko@kernel.org> - 2017-06-27 13:30 +0200
      Re: [RFC PATCH] mm, oom: allow oom reaper to race with exit_mmap Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> - 2017-06-27 13:40 +0200
        Re: [RFC PATCH] mm, oom: allow oom reaper to race with exit_mmap Michal Hocko <mhocko@kernel.org> - 2017-06-27 14:10 +0200
          Re: [RFC PATCH] mm, oom: allow oom reaper to race with exit_mmap Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> - 2017-06-27 15:40 +0200
            Re: [RFC PATCH] mm, oom: allow oom reaper to race with exit_mmap Michal Hocko <mhocko@kernel.org> - 2017-06-27 16:00 +0200
              Re: [RFC PATCH] mm, oom: allow oom reaper to race with exit_mmap Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> - 2017-06-27 16:30 +0200
                Re: [RFC PATCH] mm, oom: allow oom reaper to race with exit_mmap Michal Hocko <mhocko@kernel.org> - 2017-06-27 16:50 +0200
  Re: [RFC PATCH] mm, oom: allow oom reaper to race with exit_mmap Michal Hocko <mhocko@kernel.org> - 2017-06-29 10:50 +0200

csiph-web