Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1674845

Re: [PATCH 4/4] sched,fair: remove effective_load

From Rik van Riel <riel@redhat.com>
Newsgroups linux.kernel
Subject Re: [PATCH 4/4] sched,fair: remove effective_load
Date 2017-06-26 17:00 +0200
Message-ID <tWDEC-3EY-23@gated-at.bofh.it> (permalink)
References <tVA65-4Fr-3@gated-at.bofh.it> <tVA65-4Fr-1@gated-at.bofh.it> <tWDuW-3Bo-21@gated-at.bofh.it> <tWDuX-3Bo-41@gated-at.bofh.it>
Organization Red Hat, Inc

Show all headers | View raw

On Mon, 2017-06-26 at 16:46 +0200, Peter Zijlstra wrote:
> On Mon, Jun 26, 2017 at 04:44:37PM +0200, Peter Zijlstra wrote:
> > On Fri, Jun 23, 2017 at 12:55:30PM -0400, riel@redhat.com wrote:
> > > From: Rik van Riel <riel@redhat.com>
> > > 
> > > The function effective_load was only used by the NUMA balancing
> > > code, and not by the regular load balancing code. Now that the
> > > NUMA balancing code no longer uses it either, get rid of it.
> > 
> > Hmm,... funny. It used to be used by wake-affine. I'll have to go
> > check
> > what happened.
> 
> Ah, it fell pray to that LLC == NUMA confusion from the previous
> patch.
> 
> That really looks buggered.

Do the changelog or comments of that patch need fixing,
to avoid LLC / NUMA confusion?

I remember us talking about that in the past, but I do
not remember whether or not I changed the comments after
that discussion...

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 4/4] sched,fair: remove effective_load riel@redhat.com - 2017-06-23 19:00 +0200
  [tip:sched/core] sched/fair: Remove effective_load() tip-bot for Rik van Riel <tipbot@zytor.com> - 2017-06-24 09:30 +0200
  Re: [PATCH 4/4] sched,fair: remove effective_load Peter Zijlstra <peterz@infradead.org> - 2017-06-26 16:50 +0200
    Re: [PATCH 4/4] sched,fair: remove effective_load Peter Zijlstra <peterz@infradead.org> - 2017-06-26 16:50 +0200
      Re: [PATCH 4/4] sched,fair: remove effective_load Rik van Riel <riel@redhat.com> - 2017-06-26 17:00 +0200
        Re: [PATCH 4/4] sched,fair: remove effective_load Peter Zijlstra <peterz@infradead.org> - 2017-06-26 17:10 +0200
          Re: [PATCH 4/4] sched,fair: remove effective_load Rik van Riel <riel@redhat.com> - 2017-06-26 17:30 +0200
            Re: [PATCH 4/4] sched,fair: remove effective_load Peter Zijlstra <peterz@infradead.org> - 2017-06-26 18:20 +0200
              Re: [PATCH 4/4] sched,fair: remove effective_load Rik van Riel <riel@redhat.com> - 2017-06-26 21:40 +0200
                Re: [PATCH 4/4] sched,fair: remove effective_load Peter Zijlstra <peterz@infradead.org> - 2017-06-27 07:40 +0200
                Re: [PATCH 4/4] sched,fair: remove effective_load Rik van Riel <riel@redhat.com> - 2017-06-27 17:00 +0200
              Re: [PATCH 4/4] sched,fair: remove effective_load Rik van Riel <riel@redhat.com> - 2017-06-27 20:30 +0200

csiph-web