Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1673598
| From | Johannes Thumshirn <jthumshirn@suse.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] scsi: aacraid: Don't copy uninitialized stack memory to userspace |
| Date | 2017-06-23 16:20 +0200 |
| Message-ID | <tVxBf-3fw-5@gated-at.bofh.it> (permalink) |
| References | <tVxrA-3cr-41@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, Jun 23, 2017 at 09:04:22AM -0500, Seth Forshee wrote:
> Both aac_send_raw_srb() and aac_get_hba_info() may copy stack
> allocated structs to userspace without initializing all members
> of these structs. Clear out this memory to prevent information
> leaks.
>
> Fixes: 423400e64d377 ("scsi: aacraid: Include HBA direct interface")
> Fixes: c799d519bf088 ("scsi: aacraid: Retrieve HBA host information ioctl")
> Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
> ---
Looks good,
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
--
Johannes Thumshirn Storage
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] scsi: aacraid: Don't copy uninitialized stack memory to userspace Seth Forshee <seth.forshee@canonical.com> - 2017-06-23 16:10 +0200 Re: [PATCH] scsi: aacraid: Don't copy uninitialized stack memory to userspace Johannes Thumshirn <jthumshirn@suse.de> - 2017-06-23 16:20 +0200 Re: [PATCH] scsi: aacraid: Don't copy uninitialized stack memory to userspace "Martin K. Petersen" <martin.petersen@oracle.com> - 2017-06-26 19:40 +0200
csiph-web