Re: [PATCH] nfc: Ensure presence of required attributes in the activate_target netlink handler

From	Samuel Ortiz <sameo@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] nfc: Ensure presence of required attributes in the activate_target netlink handler
Date	2017-06-23 00:30 +0200
Message-ID	<tViLT-2eG-1@gated-at.bofh.it> (permalink)
References	<tKC1A-1db-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Mateusz,

On Wed, May 24, 2017 at 12:42:26PM +0200, Mateusz Jurczyk wrote:
> Check that the NFC_ATTR_TARGET_INDEX and NFC_ATTR_PROTOCOLS attributes (in
> addition to NFC_ATTR_DEVICE_INDEX) are provided by the netlink client
> prior to accessing them. This prevents potential unhandled NULL pointer
> dereference exceptions which can be triggered by malicious user-mode
> programs, if they omit one or both of these attributes.
> 
> Signed-off-by: Mateusz Jurczyk <mjurczyk@google.com>
> ---
>  net/nfc/netlink.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
Applied, thanks.

Cheers,
Samuel.

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] nfc: Ensure presence of required attributes in the  activate_target netlink handler Samuel Ortiz <sameo@linux.intel.com> - 2017-06-23 00:30 +0200

csiph-web