Re: [PATCH] dt-bindings: mtd: elm: Correct compatible string requirement

From	Boris Brezillon <boris.brezillon@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] dt-bindings: mtd: elm: Correct compatible string requirement
Date	2017-06-22 21:20 +0200
Message-ID	<tVfO3-rD-47@gated-at.bofh.it> (permalink)
References	<tUMVI-61A-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, 21 Jun 2017 08:22:06 -0400
Tom Rini <trini@konsulko.com> wrote:

> The binding says that the compatible string must be "ti,am33xx-elm"
> but the code checks only for, and all functioning users set, this as
> "ti,am3352-elm" so correct the binding.
> 
> Cc: David Woodhouse <dwmw2@infradead.org>
> Cc: Brian Norris <computersforpeace@gmail.com>
> Cc: Boris Brezillon <boris.brezillon@free-electrons.com>
> Cc: Marek Vasut <marek.vasut@gmail.com>
> Cc: Richard Weinberger <richard@nod.at>
> Cc: Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Signed-off-by: Tom Rini <trini@konsulko.com>

Applied.

Thanks,

Boris

> ---
> I have submitted a separate patch that correct the dm816x.dtsi to set
> the compatible string there for the elm from ti,816-elm to ti,am3352-elm
> and tested it on the hardware, where it works.  It is quite likely that
> dm814x.dtsi can be trivially corrected as it came after dm816x and
> before am335x but as I cannot test the hardware, I did not update that.
> ---
>  Documentation/devicetree/bindings/mtd/elm.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/mtd/elm.txt b/Documentation/devicetree/bindings/mtd/elm.txt
> index 8c1528c421d4..59ddc61c1076 100644
> --- a/Documentation/devicetree/bindings/mtd/elm.txt
> +++ b/Documentation/devicetree/bindings/mtd/elm.txt
> @@ -1,7 +1,7 @@
>  Error location module
>  
>  Required properties:
> -- compatible: Must be "ti,am33xx-elm"
> +- compatible: Must be "ti,am3352-elm"
>  - reg: physical base address and size of the registers map.
>  - interrupts: Interrupt number for the elm.
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] dt-bindings: mtd: elm: Correct compatible string requirement Tom Rini <trini@konsulko.com> - 2017-06-21 14:30 +0200
  Re: [PATCH] dt-bindings: mtd: elm: Correct compatible string  requirement Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-06-22 21:20 +0200

csiph-web