Re: [PATCH] scripts/dtc: dtx_diff - Show real file names in diff header

From	Rob Herring <robh@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] scripts/dtc: dtx_diff - Show real file names in diff header
Date	2017-06-22 18:30 +0200
Message-ID	<tVd9w-7bb-27@gated-at.bofh.it> (permalink)
References	<tVa1Y-5aF-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Jun 22, 2017 at 03:07:06PM +0200, Geert Uytterhoeven wrote:
> As the comparison uses process substitution to pass files after
> conversion to DTS format, the diff header doesn't show the real
> filenames, but the names of the file descriptors used:
> 
>     --- /dev/fd/63  2017-06-22 11:21:47.531637188 +0200
>     +++ /dev/fd/62  2017-06-22 11:21:47.531637188 +0200
> 
> This is especially annoying when comparing a bunch of DT files in a
> loop, as the output doesn't show a clue about which files it refers to.
> 
> Fix this by explicitly passing the original file names to the diff
> command using the --label option, giving e.g.:
> 
>     --- arch/arm/boot/dts/r8a7791-koelsch.dtb
>     +++ arch/arm/boot/dts/r8a7791-porter.dtb
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  scripts/dtc/dtx_diff | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] scripts/dtc: dtx_diff - Show real file names in diff header Geert Uytterhoeven <geert+renesas@glider.be> - 2017-06-22 15:10 +0200
  Re: [PATCH] scripts/dtc: dtx_diff - Show real file names in diff  header Frank Rowand <frowand.list@gmail.com> - 2017-06-22 18:00 +0200
  Re: [PATCH] scripts/dtc: dtx_diff - Show real file names in diff  header Rob Herring <robh@kernel.org> - 2017-06-22 18:30 +0200

csiph-web