Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1673996

Re: seccomp ptrace selftest failures with 4.4-stable [Was: Re: LTS testing with latest kselftests - some failures]

Show all headers | View raw

On Thu, Jun 22, 2017 at 07:40:49PM -0700, Andy Lutomirski wrote:
> Greg, for context, the issue here is that we made what was arguably a
> design error in seccomp's interaction with ptrace.  After determining
> that fixing it solved a bunch of problems and didn't break any user
> programs, we fixed it.  There might be new code that relies on the fix
> being present in the sense that it would be insecure without the fix.
> 
> The problem is that the fix is moderately intrusive and doesn't seem
> like a great candidate for backporting, although we could plausibly do
> it.

That's fine, not all bugfixes that tests are created to find, should be
backported.  That's up to the stable maintainers, or someone who has a
device/vendor tree based on that kernel if they want to do that or not.

That has nothing to do with the fact that the test should fail or
gracefully degrade.  Tests should fail if the action that they are
testing fails.  They should degrade and not run if the _feature_ they
are testing is not present.

Yes, sometimes this is hard, like with the seccomp stuff, and will not
always work, but that's the rule for our userspace api independant of
any testing framework or code.

Look at xfstests, no one gets mad when it adds a new test that old
kernels fail at.  It's up to someone else to either backport the kernel
change, if they want it fixed in an old kernel, not to have xfstests
just not run it at all!  There's nothing different here either.

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

seccomp ptrace selftest failures with 4.4-stable [Was: Re: LTS  testing with latest kselftests - some failures] Sumit Semwal <sumit.semwal@linaro.org> - 2017-06-22 18:20 +0200
  Re: seccomp ptrace selftest failures with 4.4-stable [Was: Re: LTS  testing with latest kselftests - some failures] Kees Cook <keescook@chromium.org> - 2017-06-22 19:00 +0200
    Re: seccomp ptrace selftest failures with 4.4-stable [Was: Re: LTS  testing with latest kselftests - some failures] Shuah Khan <shuah@kernel.org> - 2017-06-22 19:20 +0200
      Re: seccomp ptrace selftest failures with 4.4-stable [Was: Re: LTS  testing with latest kselftests - some failures] Andy Lutomirski <luto@kernel.org> - 2017-06-22 19:50 +0200
        Re: seccomp ptrace selftest failures with 4.4-stable [Was: Re: LTS  testing with latest kselftests - some failures] Kees Cook <keescook@chromium.org> - 2017-06-22 20:00 +0200
          Re: seccomp ptrace selftest failures with 4.4-stable [Was: Re: LTS  testing with latest kselftests - some failures] Shuah Khan <shuah@kernel.org> - 2017-06-22 21:10 +0200
            Re: seccomp ptrace selftest failures with 4.4-stable [Was: Re: LTS  testing with latest kselftests - some failures] Tom Gall <tom.gall@linaro.org> - 2017-06-22 21:50 +0200
              Re: seccomp ptrace selftest failures with 4.4-stable [Was: Re: LTS  testing with latest kselftests - some failures] Shuah Khan <shuah@kernel.org> - 2017-06-22 22:30 +0200
                Re: seccomp ptrace selftest failures with 4.4-stable [Was: Re: LTS  testing with latest kselftests - some failures] Sumit Semwal <sumit.semwal@linaro.org> - 2017-06-23 06:10 +0200
                Re: seccomp ptrace selftest failures with 4.4-stable [Was: Re: LTS  testing with latest kselftests - some failures] Shuah Khan <shuah@kernel.org> - 2017-06-23 17:40 +0200
              Re: seccomp ptrace selftest failures with 4.4-stable [Was: Re: LTS  testing with latest kselftests - some failures] Shuah Khan <shuah@kernel.org> - 2017-06-23 21:10 +0200
                Re: seccomp ptrace selftest failures with 4.4-stable [Was: Re: LTS  testing with latest kselftests - some failures] Tom Gall <tom.gall@linaro.org> - 2017-06-23 21:50 +0200
          Re: seccomp ptrace selftest failures with 4.4-stable [Was: Re: LTS  testing with latest kselftests - some failures] Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-06-23 04:00 +0200
            Re: seccomp ptrace selftest failures with 4.4-stable [Was: Re: LTS  testing with latest kselftests - some failures] Andy Lutomirski <luto@kernel.org> - 2017-06-23 04:50 +0200
              Re: seccomp ptrace selftest failures with 4.4-stable [Was: Re: LTS  testing with latest kselftests - some failures] Kees Cook <keescook@chromium.org> - 2017-06-23 06:10 +0200
              Re: seccomp ptrace selftest failures with 4.4-stable [Was: Re: LTS  testing with latest kselftests - some failures] "Luis R. Rodriguez" <mcgrof@kernel.org> - 2017-06-24 02:40 +0200
                Re: seccomp ptrace selftest failures with 4.4-stable [Was: Re: LTS  testing with latest kselftests - some failures] Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-06-24 06:50 +0200
                Re: seccomp ptrace selftest failures with 4.4-stable [Was: Re: LTS  testing with latest kselftests - some failures] "Luis R. Rodriguez" <mcgrof@kernel.org> - 2017-06-26 23:50 +0200
              Re: seccomp ptrace selftest failures with 4.4-stable [Was: Re: LTS  testing with latest kselftests - some failures] Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-06-24 06:50 +0200

csiph-web