Re: [PATCH NET v3 1/2] net: phy: Add phy loopback support in net phy framework

From	Yunsheng Lin <linyunsheng@huawei.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH NET v3 1/2] net: phy: Add phy loopback support in net phy framework
Date	2017-06-24 05:50 +0200
Message-ID	<tVKf8-2ER-3@gated-at.bofh.it> (permalink)
References	<tVsUW-hI-11@gated-at.bofh.it> <tVsUW-hI-17@gated-at.bofh.it> <tVJM5-2rK-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi, Andrew

On 2017/6/24 11:12, Andrew Lunn wrote:
>> +int phy_loopback(struct phy_device *phydev, bool enable)
>> +{
>> +	struct phy_driver *phydrv = to_phy_driver(phydev->mdio.dev.driver);
>> +	int ret = 0;
>> +
>> +	if (enable && phydev->loopback_enabled)
>> +		return -EBUSY;
>> +
>> +	if (!enable && !phydev->loopback_enabled)
>> +		return -EINVAL;
>> +
>> +	if (phydev->drv && phydrv->set_loopback)
>> +		ret = phydrv->set_loopback(phydev, enable);
> 
>    	else
> 		ret = -EOPNOTSUPP;
> 
>> +
>> +	if (ret)
>> +		return ret;
>> +
>> +	phydev->loopback_enabled = enable;
>> +
>> +	return 0;
>> +}
>> +EXPORT_SYMBOL(phy_loopback);
> 
> One of the comments we made of the PHY code in the hns driver is that
> its locking is completely broken. You have made the same error
> here. The core needs to hold the mutex while calling into the PHY
> driver.
Do you mean hns_nic_config_phy_loopback need to hold the mutex while
calling phy_loopback? and other place that calling phy_* function?

Best Regards
Yunsheng Lin

Thread

[PATCH NET v3 0/2] Add loopback support in phy_driver and hns ethtool fix Lin Yun Sheng <linyunsheng@huawei.com> - 2017-06-23 11:20 +0200
  [PATCH NET v3 2/2] net: hns: Use phy_driver to setup Phy loopback Lin Yun Sheng <linyunsheng@huawei.com> - 2017-06-23 11:20 +0200
    Re: [PATCH NET v3 2/2] net: hns: Use phy_driver to setup Phy loopback Andrew Lunn <andrew@lunn.ch> - 2017-06-24 05:20 +0200
  [PATCH NET v3 1/2] net: phy: Add phy loopback support in net phy framework Lin Yun Sheng <linyunsheng@huawei.com> - 2017-06-23 11:20 +0200
    Re: [PATCH NET v3 1/2] net: phy: Add phy loopback support in net phy  framework Andrew Lunn <andrew@lunn.ch> - 2017-06-24 05:20 +0200
      Re: [PATCH NET v3 1/2] net: phy: Add phy loopback support in net phy  framework Yunsheng Lin <linyunsheng@huawei.com> - 2017-06-24 05:50 +0200
        Re: [PATCH NET v3 1/2] net: phy: Add phy loopback support in net phy  framework Yunsheng Lin <linyunsheng@huawei.com> - 2017-06-24 08:20 +0200
          Re: [PATCH NET v3 1/2] net: phy: Add phy loopback support in net phy  framework Andrew Lunn <andrew@lunn.ch> - 2017-06-24 16:00 +0200

csiph-web