Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1673727

Re: [PATCH v8 3/3] mailbox: qcom: Add support for APCS clock controller

Show all headers | View raw

On Fri 23 Jun 09:15 PDT 2017, Georgi Djakov wrote:

> +static int msm8916_register_clk(struct device *dev, void __iomem *base)
> +{
[..]
> +	regmap = devm_regmap_init_mmio(dev, base, &a53cc_regmap_config);
> +	if (IS_ERR(regmap)) {
> +		ret = PTR_ERR(regmap);
> +		dev_err(dev, "failed to init regmap mmio: %d\n", ret);
> +		goto err;
> +	}

I think it would be cleaner if you create the regmap in probe() and we
use that throughout the driver - rather than using two different access
mechanism.

> +
> +	a53cc->clkr.regmap = regmap;
> +
> +	ret = devm_clk_register_regmap(dev, &a53cc->clkr);
> +	if (ret) {
> +		dev_err(dev, "failed to register regmap clock: %d\n", ret);
> +		goto err;
> +	}
> +
> +	ret = of_clk_add_hw_provider(dev->of_node, of_clk_hw_simple_get,
> +				     &a53cc->clkr.hw);
> +	if (ret) {
> +		dev_err(dev, "failed to add clock provider: %d\n", ret);
> +		goto err;
> +	}
> +
> +	return 0;
> +
> +err:
> +	clk_notifier_unregister(pclk, &a53cc->clk_nb);
> +	return ret;
> +}
> +
>  static int qcom_apcs_ipc_probe(struct platform_device *pdev)
>  {
> +	struct device_node *np = pdev->dev.of_node;
>  	struct qcom_apcs_ipc *apcs;
>  	struct resource *res;
>  	unsigned long offset;
> @@ -63,6 +178,13 @@ static int qcom_apcs_ipc_probe(struct platform_device *pdev)
>  	if (IS_ERR(base))
>  		return PTR_ERR(base);
>  
> +	if (of_device_is_compatible(np, "qcom,msm8916-apcs-kpss-global")) {
> +		/* register the APCS mux and divider clock */
> +		ret = msm8916_register_clk(&pdev->dev, base);
> +		if (ret)
> +			return ret;
> +	}
> +

Don't you need to clean up anything in the below error path and in
remove()?

>  	offset = (unsigned long)of_device_get_match_data(&pdev->dev);
>  
>  	apcs->reg = base + offset;

Other than that I think this looks reasonable.

Regards,
Bjorn

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v8 3/3] mailbox: qcom: Add support for APCS clock controller Georgi Djakov <georgi.djakov@linaro.org> - 2017-06-23 18:20 +0200
  Re: [PATCH v8 3/3] mailbox: qcom: Add support for APCS clock  controller Bjorn Andersson <bjorn.andersson@linaro.org> - 2017-06-23 19:50 +0200
    Re: [PATCH v8 3/3] mailbox: qcom: Add support for APCS clock  controller Georgi Djakov <georgi.djakov@linaro.org> - 2017-06-27 18:30 +0200
  Re: [PATCH v8 3/3] mailbox: qcom: Add support for APCS clock  controller Rob Herring <robh@kernel.org> - 2017-06-26 21:50 +0200
  Re: [PATCH v8 3/3] mailbox: qcom: Add support for APCS clock  controller Stephen Boyd <sboyd@codeaurora.org> - 2017-06-27 00:50 +0200
    Re: [PATCH v8 3/3] mailbox: qcom: Add support for APCS clock  controller Georgi Djakov <georgi.djakov@linaro.org> - 2017-06-27 18:30 +0200

csiph-web