Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1671895

[PATCH 14/25] perf intel-pt: Clear FUP flag on error

From Arnaldo Carvalho de Melo <acme@kernel.org>
Newsgroups linux.kernel
Subject [PATCH 14/25] perf intel-pt: Clear FUP flag on error
Date 2017-06-21 20:10 +0200
Message-ID <tUSeL-1fP-69@gated-at.bofh.it> (permalink)
References <tUSeJ-1fP-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


From: Adrian Hunter <adrian.hunter@intel.com>

Sometimes a FUP packet is associated with a TSX transaction and a flag is
set to indicate that. Ensure that flag is cleared on any error condition
because at that point the decoder can no longer assume it is correct.

Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: stable@vger.kernel.org
Link: http://lkml.kernel.org/r/1495786658-18063-9-git-send-email-adrian.hunter@intel.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/util/intel-pt-decoder/intel-pt-decoder.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tools/perf/util/intel-pt-decoder/intel-pt-decoder.c b/tools/perf/util/intel-pt-decoder/intel-pt-decoder.c
index 923c60efda26..a97710162e07 100644
--- a/tools/perf/util/intel-pt-decoder/intel-pt-decoder.c
+++ b/tools/perf/util/intel-pt-decoder/intel-pt-decoder.c
@@ -1962,6 +1962,8 @@ static int intel_pt_sync_ip(struct intel_pt_decoder *decoder)
 {
 	int err;
 
+	decoder->set_fup_tx_flags = false;
+
 	intel_pt_log("Scanning for full IP\n");
 	err = intel_pt_walk_to_ip(decoder);
 	if (err)
-- 
2.9.4

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[GIT PULL 00/25] perf/core improvements and fixes Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-06-21 20:10 +0200
  [PATCH 09/25] perf intel-pt: Fix missing stack clear Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-06-21 20:10 +0200
  [PATCH 07/25] perf intel-pt: Move decoder error setting into one condition Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-06-21 20:10 +0200
  [PATCH 23/25] perf intel-pt: Fix transactions_sample_type Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-06-21 20:10 +0200
  [PATCH 04/25] tools lib api fs: Add sysfs__write_int function Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-06-21 20:10 +0200
  [PATCH 05/25] perf stat: Add support to measure SMI cost Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-06-21 20:10 +0200
  [PATCH 19/25] perf intel-pt: Add decoder support for ptwrite and power event packets Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-06-21 20:10 +0200
  [PATCH 22/25] perf intel-pt: Remove redundant initial_skip checks Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-06-21 20:10 +0200
  [PATCH 08/25] perf intel-pt: Improve sample timestamp Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-06-21 20:10 +0200
  [PATCH 25/25] perf script: Fix message because field list option is -F not -f Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-06-21 20:10 +0200
  [PATCH 20/25] perf intel-pt: Add reserved byte to CBR packet payload Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-06-21 20:10 +0200
  [PATCH 11/25] perf intel-pt: Fix last_ip usage Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-06-21 20:10 +0200
  [PATCH 14/25] perf intel-pt: Clear FUP flag on error Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-06-21 20:10 +0200
  [PATCH 10/25] perf intel-pt: Ensure IP is zero when state is INTEL_PT_STATE_NO_IP Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-06-21 20:10 +0200
  Re: [GIT PULL 00/25] perf/core improvements and fixes Ingo Molnar <mingo@kernel.org> - 2017-06-21 20:20 +0200

csiph-web