Re: [PATCH] staging: sm750fb: move common locking code to a macro

From	Greg KH <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] staging: sm750fb: move common locking code to a macro
Date	2017-06-21 16:40 +0200
Message-ID	<tUOXv-7i3-9@gated-at.bofh.it> (permalink)
References	<tUuP9-2YK-49@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Jun 20, 2017 at 06:50:13PM +0200, Dhananjay Balan wrote:
> The locking and unlocking code used by copy routines is common, so
> moved it to a macro.

Ick, no, never "hide" locks like this, that's not good at all.  We want
to see the locks in the code where it happens, otherwise it is not
obvious as to what is going on.

sorry,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] staging: sm750fb: move common locking code to a macro Dhananjay Balan <mail@dbalan.in> - 2017-06-20 19:10 +0200
  Re: [PATCH] staging: sm750fb: move common locking code to a macro Dan Carpenter <dan.carpenter@oracle.com> - 2017-06-20 22:10 +0200
    Re: [PATCH] staging: sm750fb: move common locking code to a macro Dhananjay Balan <mail@dbalan.in> - 2017-06-21 11:10 +0200
      Re: [PATCH] staging: sm750fb: move common locking code to a macro Dan Carpenter <dan.carpenter@oracle.com> - 2017-06-21 11:20 +0200
  Re: [PATCH] staging: sm750fb: move common locking code to a macro Greg KH <gregkh@linuxfoundation.org> - 2017-06-21 16:40 +0200

csiph-web