[PATCH] backlight: lm3630a: bump REG_MAX value to 0x50 instead of 0x1F

From	Bhushan Shah <bshah@kde.org>
Newsgroups	linux.kernel
Subject	[PATCH] backlight: lm3630a: bump REG_MAX value to 0x50 instead of 0x1F
Date	2017-06-21 07:40 +0200
Message-ID	<tUGwV-1WC-7@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

In the lm3630a_chip_init we try to write to 0x50 register, which is
higher value then the max_register value, this resulted in regmap_write
return -EIO.

Fix this by bumping REG_MAX value to 0x50.

Signed-off-by: Bhushan Shah <bshah@kde.org>
Suggested-by: Bjorn Andersson <bjorn.andersson@linaro.org>
---
 drivers/video/backlight/lm3630a_bl.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/video/backlight/lm3630a_bl.c b/drivers/video/backlight/lm3630a_bl.c
index 60d6c2ac87aa..42496b6c09d0 100644
--- a/drivers/video/backlight/lm3630a_bl.c
+++ b/drivers/video/backlight/lm3630a_bl.c
@@ -31,7 +31,8 @@
 #define REG_FAULT	0x0B
 #define REG_PWM_OUTLOW	0x12
 #define REG_PWM_OUTHIGH	0x13
-#define REG_MAX		0x1F
+#define REG_FLTR_STR	0x50
+#define REG_MAX		0x50
 
 #define INT_DEBOUNCE_MSEC	10
 struct lm3630a_chip {
@@ -80,7 +81,7 @@ static int lm3630a_chip_init(struct lm3630a_chip *pchip)
 
 	usleep_range(1000, 2000);
 	/* set Filter Strength Register */
-	rval = lm3630a_write(pchip, 0x50, 0x03);
+	rval = lm3630a_write(pchip, FLTR_STR, 0x03);
 	/* set Cofig. register */
 	rval |= lm3630a_update(pchip, REG_CONFIG, 0x07, pdata->pwm_ctrl);
 	/* set boost control */
-- 
2.13.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] backlight: lm3630a: bump REG_MAX value to 0x50 instead of 0x1F Bhushan Shah <bshah@kde.org> - 2017-06-21 07:40 +0200
  [PATCH v2] backlight: lm3630a: bump REG_MAX value to 0x50 instead of 0x1F Bhushan Shah <bshah@kde.org> - 2017-06-21 07:40 +0200
    Re: [PATCH v2] backlight: lm3630a: bump REG_MAX value to 0x50 instead  of 0x1F Daniel Thompson <daniel.thompson@linaro.org> - 2017-06-21 11:40 +0200
      Re: [PATCH v2] backlight: lm3630a: bump REG_MAX value to 0x50  instead of 0x1F Bhushan Shah <bshah@kde.org> - 2017-06-21 13:10 +0200
  Re: [PATCH] backlight: lm3630a: bump REG_MAX value to 0x50 instead  of 0x1F kbuild test robot <lkp@intel.com> - 2017-06-22 02:50 +0200

csiph-web