Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1664718

Re: [PATCH] powerpc: dts: use #include "..." to include local DT

From Michael Ellerman <mpe@ellerman.id.au>
Newsgroups linux.kernel
Subject Re: [PATCH] powerpc: dts: use #include "..." to include local DT
Date 2017-06-13 12:30 +0200
Message-ID <tRRfb-6Mo-19@gated-at.bofh.it> (permalink)
References <tKwSd-6hv-1@gated-at.bofh.it> <tQo5B-84n-45@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Masahiro Yamada <yamada.masahiro@socionext.com> writes:

> Hi
>
> (+Anatolij Gustschin <agust@denx.de>)
>
>
> Ping.
> I am not 100% sure who is responsible for this,
> but somebody, could take a look at this patch, please?

Have you tested it actually works?

It sounds reasonable, and if it behaves as you describe there is no
change in behaviour, right?

cheers

> 2017-05-24 14:12 GMT+09:00 Masahiro Yamada <yamada.masahiro@socionext.com>:
>> Most of DT files in PowerPC use #include "..." to make pre-processor
>> include DT in the same directory, but we have 3 exceptional files
>> that use #include <...> for that.
>>
>> Fix them to remove -I$(srctree)/arch/$(SRCARCH)/boot/dts path from
>> dtc_cpp_flags.
>>
>> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>> ---
>>
>>  arch/powerpc/boot/dts/ac14xx.dts     | 2 +-
>>  arch/powerpc/boot/dts/mpc5121ads.dts | 2 +-
>>  arch/powerpc/boot/dts/pdm360ng.dts   | 2 +-
>>  3 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/arch/powerpc/boot/dts/ac14xx.dts b/arch/powerpc/boot/dts/ac14xx.dts
>> index 27fcabc2f857..83bcfd865167 100644
>> --- a/arch/powerpc/boot/dts/ac14xx.dts
>> +++ b/arch/powerpc/boot/dts/ac14xx.dts
>> @@ -10,7 +10,7 @@
>>   */
>>
>>
>> -#include <mpc5121.dtsi>
>> +#include "mpc5121.dtsi"
>>
>>  / {
>>         model = "ac14xx";
>> diff --git a/arch/powerpc/boot/dts/mpc5121ads.dts b/arch/powerpc/boot/dts/mpc5121ads.dts
>> index 75888ce2c792..73c30621429b 100644
>> --- a/arch/powerpc/boot/dts/mpc5121ads.dts
>> +++ b/arch/powerpc/boot/dts/mpc5121ads.dts
>> @@ -9,7 +9,7 @@
>>   * option) any later version.
>>   */
>>
>> -#include <mpc5121.dtsi>
>> +#include "mpc5121.dtsi"
>>
>>  / {
>>         model = "mpc5121ads";
>> diff --git a/arch/powerpc/boot/dts/pdm360ng.dts b/arch/powerpc/boot/dts/pdm360ng.dts
>> index 0cec7244abe7..445b88114009 100644
>> --- a/arch/powerpc/boot/dts/pdm360ng.dts
>> +++ b/arch/powerpc/boot/dts/pdm360ng.dts
>> @@ -13,7 +13,7 @@
>>   * option) any later version.
>>   */
>>
>> -#include <mpc5121.dtsi>
>> +#include "mpc5121.dtsi"
>>
>>  / {
>>         model = "pdm360ng";
>> --
>> 2.7.4
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe devicetree" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
>
>
> -- 
> Best Regards
> Masahiro Yamada

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [PATCH] powerpc: dts: use #include "..." to include local DT Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-06-09 11:10 +0200
  Re: [PATCH] powerpc: dts: use #include "..." to include local DT Michael Ellerman <mpe@ellerman.id.au> - 2017-06-13 12:30 +0200
    Re: [PATCH] powerpc: dts: use #include "..." to include local DT Anatolij Gustschin <agust@denx.de> - 2017-06-13 15:20 +0200
    Re: [PATCH] powerpc: dts: use #include "..." to include local DT Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-06-14 08:00 +0200
      Re: [PATCH] powerpc: dts: use #include "..." to include local DT Michael Ellerman <mpe@ellerman.id.au> - 2017-06-14 08:50 +0200

csiph-web