Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1664481

[PATCH V1 3/3] pinctrl: qcom: spmi-gpio: Correct power_source range check

From fenglinw@codeaurora.org
Newsgroups linux.kernel
Subject [PATCH V1 3/3] pinctrl: qcom: spmi-gpio: Correct power_source range check
Date 2017-06-13 08:30 +0200
Message-ID <tRNuW-4sb-5@gated-at.bofh.it> (permalink)
References <tRNlf-4p4-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


From: Fenglin Wu <fenglinw@codeaurora.org>

Power source selection in DIG_VIN_CTL is indexed from 0, in the range
check it shouldn't be equal to the total number of power sources.

Signed-off-by: Fenglin Wu <fenglinw@codeaurora.org>
---
 drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
index 581309d..1fd677c 100644
--- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
+++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
@@ -500,7 +500,7 @@ static int pmic_gpio_config_set(struct pinctrl_dev *pctldev, unsigned int pin,
 			pad->is_enabled = false;
 			break;
 		case PIN_CONFIG_POWER_SOURCE:
-			if (arg > pad->num_sources)
+			if (arg >= pad->num_sources)
 				return -EINVAL;
 			pad->power_source = arg;
 			break;
-- 
Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project.

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH V1 0/3] Add LV/MV subtypes support for QCOM PMIC GPIOs fenglinw@codeaurora.org - 2017-06-13 08:20 +0200
  [PATCH V1 1/3] pinctrl: qcom: spmi-gpio: Add support for GPIO LV/MV subtype fenglinw@codeaurora.org - 2017-06-13 08:20 +0200
    Re: [PATCH V1 1/3] pinctrl: qcom: spmi-gpio: Add support for GPIO  LV/MV subtype Rob Herring <robh@kernel.org> - 2017-06-18 16:10 +0200
      Re: [PATCH V1 1/3] pinctrl: qcom: spmi-gpio: Add support for GPIO  LV/MV subtype Fenglin Wu <fenglinw@codeaurora.org> - 2017-06-19 03:10 +0200
        Re: [PATCH V1 1/3] pinctrl: qcom: spmi-gpio: Add support for GPIO  LV/MV subtype Fenglin Wu <fenglinw@codeaurora.org> - 2017-06-19 04:10 +0200
  [PATCH V1 3/3] pinctrl: qcom: spmi-gpio: Correct power_source range check fenglinw@codeaurora.org - 2017-06-13 08:30 +0200
  [PATCH V1 2/3] pinctrl: qcom: spmi-gpio: Add dtest route for digital input fenglinw@codeaurora.org - 2017-06-13 08:30 +0200
    Re: [PATCH V1 2/3] pinctrl: qcom: spmi-gpio: Add dtest route for  digital input Rob Herring <robh@kernel.org> - 2017-06-18 16:10 +0200

csiph-web