Re: [PATCH 0/3] x86: stack alignment for boot code and clang

From	Ingo Molnar <mingo@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 0/3] x86: stack alignment for boot code and clang
Date	2017-06-13 08:40 +0200
Message-ID	<tRNEC-4v8-9@gated-at.bofh.it> (permalink)
References	<tRIlz-10C-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

* Matthias Kaehlcke <mka@chromium.org> wrote:

> This series fixes an issue with the stack of the x86 boot code not
> being aligned as intended. Further it adapts the Makefile to account
> for the fact that clang uses a different option to configure the
> stack alignment than gcc (-mstack-alignment=N vs
> -mpreferred-stack-boundary=N)
> 
> Matthias Kaehlcke (3):
>   kbuild: Add cc-option-no-kbuild macro
>   x86/build: Use cc-option-no-kbuild for boot code compiler options
>   x86/build: Specify stack alignment for clang
> 
>  arch/x86/Makefile      | 25 +++++++++++++++++--------
>  scripts/Kbuild.include |  5 +++++
>  2 files changed, 22 insertions(+), 8 deletions(-)

Looks good to me, modulo the minor comments I just made to the #3 patch.

This needs acks from the kbuild people before I can apply the fixes.

Thanks,

	Ingo

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] x86: stack alignment for boot code and clang Matthias Kaehlcke <mka@chromium.org> - 2017-06-13 03:00 +0200
  [PATCH 2/3] x86/build: Use cc-option-no-kbuild for boot code compiler options Matthias Kaehlcke <mka@chromium.org> - 2017-06-13 03:00 +0200
  [PATCH 3/3] x86/build: Specify stack alignment for clang Matthias Kaehlcke <mka@chromium.org> - 2017-06-13 03:00 +0200
    Re: [PATCH 3/3] x86/build: Specify stack alignment for clang Ingo Molnar <mingo@kernel.org> - 2017-06-13 08:40 +0200
      Re: [PATCH 3/3] x86/build: Specify stack alignment for clang Matthias Kaehlcke <mka@chromium.org> - 2017-06-13 19:30 +0200
  [PATCH 1/3] kbuild: Add cc-option-no-kbuild macro Matthias Kaehlcke <mka@chromium.org> - 2017-06-13 03:00 +0200
    Re: [PATCH 1/3] kbuild: Add cc-option-no-kbuild macro Michal Marek <mmarek@suse.com> - 2017-06-13 09:50 +0200
      Re: [PATCH 1/3] kbuild: Add cc-option-no-kbuild macro Arnd Bergmann <arnd@arndb.de> - 2017-06-13 10:40 +0200
        Re: [PATCH 1/3] kbuild: Add cc-option-no-kbuild macro Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-06-13 12:20 +0200
          Re: [PATCH 1/3] kbuild: Add cc-option-no-kbuild macro Matthias Kaehlcke <mka@chromium.org> - 2017-06-13 18:50 +0200
  Re: [PATCH 0/3] x86: stack alignment for boot code and clang Ingo Molnar <mingo@kernel.org> - 2017-06-13 08:40 +0200

csiph-web