Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1664442

[PATCH v2 4/4] arm64: dts: rockchip: use cs-gpios for cros_ec_spi

From Jeffy Chen <jeffy.chen@rock-chips.com>
Newsgroups linux.kernel
Subject [PATCH v2 4/4] arm64: dts: rockchip: use cs-gpios for cros_ec_spi
Date 2017-06-13 07:30 +0200
Message-ID <tRMyS-3SC-7@gated-at.bofh.it> (permalink)
References <tRMyR-3SC-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


The cros_ec requires CS line to be active after last message. But the CS
would be toggled when powering off/on rockchip spi, which breaks ec xfer.
Use GPIO CS to prevent that.

Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
---

Changes in v2:
Fix wrong pinconf for spi5_cs0.

 arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi
index eb50593..b34a51d 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi
@@ -790,6 +790,8 @@ ap_i2c_audio: &i2c8 {
 &spi5 {
 	status = "okay";
 
+	cs-gpios = <&gpio2 23 GPIO_ACTIVE_HIGH>;
+
 	cros_ec: ec@0 {
 		compatible = "google,cros-ec-spi";
 		reg = <0>;
@@ -813,6 +815,10 @@ ap_i2c_audio: &i2c8 {
 	};
 };
 
+&spi5_cs0 {
+	rockchip,pins = <RK_GPIO2 23 RK_FUNC_GPIO &pcfg_output_high>;
+};
+
 &tsadc {
 	status = "okay";
 
-- 
2.1.4

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

[PATCH v2 4/4] arm64: dts: rockchip: use cs-gpios for cros_ec_spi Jeffy Chen <jeffy.chen@rock-chips.com> - 2017-06-13 07:30 +0200
  Re: [PATCH v2 4/4] arm64: dts: rockchip: use cs-gpios for cros_ec_spi Brian Norris <briannorris@chromium.org> - 2017-06-13 20:00 +0200
    Re: [PATCH v2 4/4] arm64: dts: rockchip: use cs-gpios for cros_ec_spi Mark Brown <broonie@kernel.org> - 2017-06-13 20:30 +0200

csiph-web