Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1662986
| From | Andrew Lunn <andrew@lunn.ch> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH net-next 8/9] net: hns3: Add support of debugfs interface to HNS3 driver |
| Date | 2017-06-10 18:40 +0200 |
| Message-ID | <tQRAC-19q-13@gated-at.bofh.it> (permalink) |
| References | <tQFzr-1TZ-3@gated-at.bofh.it> <tQFzr-1TZ-1@gated-at.bofh.it> <tQO9I-78u-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Sat, Jun 10, 2017 at 12:51:57PM +0000, Mintz, Yuval wrote:
> > This adds the support of the debugfs interface to the driver for debugging
> > purposes.
>
> > +const struct hclge_support_cmd support_cmd[] = {
> > + {"send cmd", 8, hclge_dbg_send,
> > + "opcode flag data0 data1 data2 data3 data4 data5"},
> > + {"help", 4, hclge_dbg_usage, "no option"}, };
>
> Is there an actual description of what this does? Or is it simply a huge backdoor?
It looks like a huge backdoor to the chip.
It is O.K. to have such a patch internally for your own development
work, but it should not be submitted for mainline.
NACK
Andrew
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH net-next 8/9] net: hns3: Add support of debugfs interface to HNS3 driver Salil Mehta <salil.mehta@huawei.com> - 2017-06-10 05:50 +0200
RE: [PATCH net-next 8/9] net: hns3: Add support of debugfs interface to HNS3 driver "Mintz, Yuval" <Yuval.Mintz@cavium.com> - 2017-06-10 15:00 +0200
Re: [PATCH net-next 8/9] net: hns3: Add support of debugfs interface to HNS3 driver Andrew Lunn <andrew@lunn.ch> - 2017-06-10 18:40 +0200
RE: [PATCH net-next 8/9] net: hns3: Add support of debugfs interface to HNS3 driver Salil Mehta <salil.mehta@huawei.com> - 2017-06-13 19:20 +0200
RE: [PATCH net-next 8/9] net: hns3: Add support of debugfs interface to HNS3 driver Salil Mehta <salil.mehta@huawei.com> - 2017-06-13 19:20 +0200
csiph-web