Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1658416
| From | Sagi Grimberg <sagi@grimberg.me> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v4 5/8] nvme: get list of namespace descriptors |
| Date | 2017-06-06 09:20 +0200 |
| Message-ID | <tPgWt-5BA-3@gated-at.bofh.it> (permalink) |
| References | <tOB6V-3JJ-5@gated-at.bofh.it> <tOB6V-3JJ-7@gated-at.bofh.it> <tOSUb-79A-27@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 05/06/17 08:38, Christoph Hellwig wrote: >> + } >> + len = NVME_NIDT_UUID_LEN; >> + memcpy(ns->uuid, data + pos + sizeof(*cur), len); >> + break; >> + default: >> + dev_warn(ns->ctrl->dev, >> + "Invalid Namespace Identification Descriptor Type: %d\n", >> + cur->nidt); >> + return; > > Please drop the warning and return, the spec says hosts should ignore > unknown types. This is important to future proof for new types that > could be added. Also, please stay consistent with the rest of the driver by logging the correct device prefix using ctrl->device and not ctrl->dev. (if we have some ctrl->dev left-overs, can you also send a patch to fix?)
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v4 5/8] nvme: get list of namespace descriptors Johannes Thumshirn <jthumshirn@suse.de> - 2017-06-04 12:40 +0200
Re: [PATCH v4 5/8] nvme: get list of namespace descriptors Sagi Grimberg <sagi@grimberg.me> - 2017-06-04 17:10 +0200
Re: [PATCH v4 5/8] nvme: get list of namespace descriptors Christoph Hellwig <hch@lst.de> - 2017-06-05 07:40 +0200
Re: [PATCH v4 5/8] nvme: get list of namespace descriptors Sagi Grimberg <sagi@grimberg.me> - 2017-06-06 09:20 +0200
Re: [PATCH v4 5/8] nvme: get list of namespace descriptors Hannes Reinecke <hare@suse.de> - 2017-06-06 08:30 +0200
csiph-web