Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1658110
| From | "J. Bruce Fields" <bfields@fieldses.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] virtio_net: lower limit on buffer size |
| Date | 2017-06-05 21:40 +0200 |
| Message-ID | <tP615-73d-33@gated-at.bofh.it> (permalink) |
| References | <tNIat-14h-1@gated-at.bofh.it> <tNRdM-7Cl-7@gated-at.bofh.it> <tO1mN-5Va-1@gated-at.bofh.it> <tOnGG-39t-15@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Sat, Jun 03, 2017 at 11:17:30PM +0300, Sergei Shtylyov wrote:
> On 06/02/2017 11:25 PM, J. Bruce Fields wrote:
>
> >>>commit d85b758f72b0 "virtio_net: fix support for small rings"
> >>
> >> Commit d85b758f72b0 ("virtio_net: fix support for small rings")
> >>
> >>>was supposed to increase the buffer size for small rings
> >>>but had an unintentional side effect of decreasing
> >>>it for large rings. This seems to break some setups -
> >>>it's not yet clear why, but increasing buffer size
> >>>back to what it was before helps.
> >>>
> >>>Fixes: d85b758f72b0 "virtio_net: fix support for small rings"
> >>
> >>Fixes: d85b758f72b0 ("virtio_net: fix support for small rings")
> >
> >I may be bikeshedding, but, personally I never do the parens--they're
> >redundant given the quotes, and space is often tight.
>
> Just see Documetation/process/submitting-patches.rst.
Yeah, I know, I claim it's a bad rule (but I'm too lazy to send a patch,
so, weight my opinion accordingly).
--b.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] virtio_net: lower limit on buffer size "Michael S. Tsirkin" <mst@redhat.com> - 2017-06-02 02:00 +0200
Re: [PATCH] virtio_net: lower limit on buffer size "J. Bruce Fields" <bfields@fieldses.org> - 2017-06-02 04:00 +0200
Re: [PATCH] virtio_net: lower limit on buffer size Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2017-06-02 11:40 +0200
Re: [PATCH] virtio_net: lower limit on buffer size "J. Bruce Fields" <bfields@fieldses.org> - 2017-06-02 22:30 +0200
Re: [PATCH] virtio_net: lower limit on buffer size Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2017-06-03 22:20 +0200
Re: [PATCH] virtio_net: lower limit on buffer size "J. Bruce Fields" <bfields@fieldses.org> - 2017-06-05 21:40 +0200
Re: [PATCH] virtio_net: lower limit on buffer size Mikulas Patocka <mpatocka@redhat.com> - 2017-06-02 15:20 +0200
csiph-web