Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1657969
| From | Stefano Stabellini <sstabellini@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 3/3] arm/xen: Adjust one function call together with a variable assignment |
| Date | 2017-06-05 19:20 +0200 |
| Message-ID | <tP3PA-5Lk-19@gated-at.bofh.it> (permalink) |
| References | <tOKWB-1Yk-1@gated-at.bofh.it> <tOKWB-1Yk-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Sun, 4 Jun 2017, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sun, 4 Jun 2017 21:21:20 +0200
>
> The script "checkpatch.pl" pointed information out like the following.
>
> ERROR: do not use assignment in if condition
>
> Thus fix the affected source code place.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> ---
> arch/arm/xen/p2m.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/xen/p2m.c b/arch/arm/xen/p2m.c
> index f5f74ac637b9..e71eefa2e427 100644
> --- a/arch/arm/xen/p2m.c
> +++ b/arch/arm/xen/p2m.c
> @@ -153,7 +153,8 @@ bool __set_phys_to_machine_multi(unsigned long pfn,
> p2m_entry->mfn = mfn;
>
> write_lock_irqsave(&p2m_lock, irqflags);
> - if ((rc = xen_add_phys_to_mach_entry(p2m_entry)) < 0) {
> + rc = xen_add_phys_to_mach_entry(p2m_entry);
> + if (rc < 0) {
> write_unlock_irqrestore(&p2m_lock, irqflags);
> return false;
> }
> --
> 2.13.0
>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/3] ARM-XEN: Adjustments for __set_phys_to_machine_multi() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-06-04 23:10 +0200
[PATCH 3/3] arm/xen: Adjust one function call together with a variable assignment SF Markus Elfring <elfring@users.sourceforge.net> - 2017-06-04 23:10 +0200
Re: [PATCH 3/3] arm/xen: Adjust one function call together with a variable assignment Stefano Stabellini <sstabellini@kernel.org> - 2017-06-05 19:20 +0200
[PATCH 2/3] arm/xen: Delete an error message for a failed memory allocation in __set_phys_to_machine_multi() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-06-04 23:10 +0200
Re: [PATCH 2/3] arm/xen: Delete an error message for a failed memory allocation in __set_phys_to_machine_multi() Stefano Stabellini <sstabellini@kernel.org> - 2017-06-05 19:20 +0200
[PATCH 1/3] arm/xen: Improve a size determination in __set_phys_to_machine_multi() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-06-04 23:10 +0200
Re: [PATCH 1/3] arm/xen: Improve a size determination in __set_phys_to_machine_multi() Stefano Stabellini <sstabellini@kernel.org> - 2017-06-05 19:20 +0200
Re: [PATCH 0/3] ARM-XEN: Adjustments for __set_phys_to_machine_multi() Stefano Stabellini <sstabellini@kernel.org> - 2017-06-05 20:00 +0200
csiph-web