Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1657590

Re: [PATCH v2] misc: atmel-ssc: Handle return value of clk_prepare_enable and clk_prepare

Show all headers | View raw

On 05/06/2017 at 14:05:15 +0200, Greg KH wrote:
> On Mon, Jun 05, 2017 at 11:36:52AM +0200, Alexandre Belloni wrote:
> > On 05/06/2017 at 14:53:30 +0530, Arvind Yadav wrote:
> > > Hi,
> > > 
> > > Yes, Patch v1 was wrong that's why i have push v2.
> > > clk_prepare and clk_prepare_enable can fail. There
> > 
> > No this is not true, they will never fail for the SSC.
> 
> How is anyone supposed to know this?  Just check the functions correctly
> and move on, if they can never fail, wonderful, that's a code path that
> is not going to be run.
> 

Anyone able (and taking the time) to read code can know that.

I'm really not okay with having useless code paths. Many people are
already complaining (rightfully) that the kernel is bloated, let's try
to not make the situation worse and keep in mind that Linux can run on
tiny SoCs.

> > > is not harm to check it's return value. It'll not impact present
> > > functionality.
> > > 
> > 
> > It does impact boot time, this patch adds 112 bytes to a compressed
> > kernel for no reason.
> 
> It solves the issue that if someone copy/paste from this code, they will
> implement something incorrectly.  You can spare the 112 bytes (which
> really, seems very large for just 2 error cases, are you sure that's
> right?  Just drop the string if you care about size here.
> 

I'm sure about the size, I've measured it on top of v4.12-rc1 before
replying.

I don't think anyone will copy/paste from this code but if that happen
and is missed by the maintainer, I'm pretty sure someone will be quick
to run his preferred static analysis tool and send a patch (hopefully,
testing it really compiles first).


> thanks,
> 
> greg k-h

-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2] misc: atmel-ssc: Handle return value of clk_prepare_enable and clk_prepare Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-06-02 07:40 +0200
  Re: [PATCH v2] misc: atmel-ssc: Handle return value of  clk_prepare_enable and clk_prepare Greg KH <gregkh@linuxfoundation.org> - 2017-06-03 16:20 +0200
  Re: [PATCH v2] misc: atmel-ssc: Handle return value of  clk_prepare_enable and clk_prepare Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-06-04 00:20 +0200
    Re: [PATCH v2] misc: atmel-ssc: Handle return value of  clk_prepare_enable and clk_prepare Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-06-05 11:30 +0200
      Re: [PATCH v2] misc: atmel-ssc: Handle return value of  clk_prepare_enable and clk_prepare Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-06-05 11:40 +0200
        Re: [PATCH v2] misc: atmel-ssc: Handle return value of  clk_prepare_enable and clk_prepare Greg KH <gregkh@linuxfoundation.org> - 2017-06-05 14:10 +0200
          Re: [PATCH v2] misc: atmel-ssc: Handle return value of  clk_prepare_enable and clk_prepare Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-06-05 15:20 +0200

csiph-web