Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1654226

Re: [PATCH] bcm47xx: fix build regression

Show all headers | View raw

On Wed, May 31, 2017 at 12:21:10PM +0200, Arnd Bergmann wrote:
> On Wed, May 31, 2017 at 11:43 AM, Arend van Spriel
> <arend.vanspriel@broadcom.com> wrote:
> > On 5/30/2017 1:20 PM, Arnd Bergmann wrote:
> >>
> >> An unknown change in the kernel headers caused a build regression
> >> in an MTD partition driver:
> >>
> >> In file included from drivers/mtd/bcm47xxpart.c:12:0:
> >> include/linux/bcm47xx_nvram.h: In function 'bcm47xx_nvram_init_from_mem':
> >> include/linux/bcm47xx_nvram.h:27:10: error: 'ENOTSUPP' undeclared (first
> >> use in this function)
> >>
> >> Clearly we want to include linux/errno.h here.
> >
> >
> > unfortunate that you did not find the commit that caused this build
> > regression. You could produce preprocessor output when it was working to see
> > where errno.h got implicitly included and start looking there for git
> > history.
> 
> I did a 'git bisect run make drivers/mtd/bcm47xxpart.o' now, which pointed to
> 0bc2d534708b ("rcu: Refactor #includes from include/linux/rcupdate.h").
> 
> That commit seems reasonable, it was just bad luck that it caused this
> regression. The commit is currently in the rcu/rcu/next branch of tip.git,
> so Paul could merge the patch there.

Apologies for the inconvenience, not sure why 0day test robot didn't
find this.  Probably because it cannot test each and every driver.  ;-)

This patch, correct?

	https://lkml.org/lkml/2017/5/30/348

							Thanx, Paul

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] bcm47xx: fix build regression Arnd Bergmann <arnd@arndb.de> - 2017-05-30 13:30 +0200
  Re: [PATCH] bcm47xx: fix build regression Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-05-31 11:20 +0200
  Re: [PATCH] bcm47xx: fix build regression Arend van Spriel <arend.vanspriel@broadcom.com> - 2017-05-31 11:50 +0200
    Re: [PATCH] bcm47xx: fix build regression Arnd Bergmann <arnd@arndb.de> - 2017-05-31 12:30 +0200
      Re: [PATCH] bcm47xx: fix build regression "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2017-05-31 15:20 +0200
        Re: [PATCH] bcm47xx: fix build regression Arnd Bergmann <arnd@arndb.de> - 2017-05-31 15:40 +0200
          Re: [PATCH] bcm47xx: fix build regression "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2017-05-31 18:40 +0200
            Re: [PATCH] bcm47xx: fix build regression Arend van Spriel <arend.vanspriel@broadcom.com> - 2017-05-31 21:40 +0200
              Re: [PATCH] bcm47xx: fix build regression "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2017-06-02 00:20 +0200

csiph-web