Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1655882

[PATCH] media: platform: s3c-camif: fix arguments position in function call

From "Gustavo A. R. Silva" <garsilva@embeddedor.com>
Newsgroups linux.kernel
Subject [PATCH] media: platform: s3c-camif: fix arguments position in function call
Date 2017-06-02 05:50 +0200
Message-ID <tNLL4-3EL-1@gated-at.bofh.it> (permalink)
References <tNFZ0-8b0-13@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Hi Sylwester,

Here is another patch in case you decide that it is
better to apply this one.

Thanks
--
Gustavo A. R. Silva


==========

Fix the position of the arguments in function call.

Addresses-Coverity-ID: 1248800
Addresses-Coverity-ID: 1269141
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
 drivers/media/platform/s3c-camif/camif-capture.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/media/platform/s3c-camif/camif-capture.c b/drivers/media/platform/s3c-camif/camif-capture.c
index 1b30be72..25c7a7d 100644
--- a/drivers/media/platform/s3c-camif/camif-capture.c
+++ b/drivers/media/platform/s3c-camif/camif-capture.c
@@ -80,7 +80,7 @@ static int s3c_camif_hw_init(struct camif_dev *camif, struct camif_vp *vp)
 	camif_hw_set_test_pattern(camif, camif->test_pattern);
 	if (variant->has_img_effect)
 		camif_hw_set_effect(camif, camif->colorfx,
-				camif->colorfx_cb, camif->colorfx_cr);
+				camif->colorfx_cr, camif->colorfx_cb);
 	if (variant->ip_revision == S3C6410_CAMIF_IP_REV)
 		camif_hw_set_input_path(vp);
 	camif_cfg_video_path(vp);
@@ -364,7 +364,7 @@ irqreturn_t s3c_camif_irq_handler(int irq, void *priv)
 		camif_hw_set_test_pattern(camif, camif->test_pattern);
 		if (camif->variant->has_img_effect)
 			camif_hw_set_effect(camif, camif->colorfx,
-				    camif->colorfx_cb, camif->colorfx_cr);
+				    camif->colorfx_cr, camif->colorfx_cb);
 		vp->state &= ~ST_VP_CONFIG;
 	}
 unlock:
-- 
2.5.0

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [PATCH] media: platform: s3c-camif: fix function prototype Sylwester Nawrocki <sylvester.nawrocki@gmail.com> - 2017-06-01 23:40 +0200
  [PATCH] media: platform: s3c-camif: fix arguments position in  function call "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-06-02 05:50 +0200
    Re: [PATCH] media: platform: s3c-camif: fix arguments position in  function call Sylwester Nawrocki <s.nawrocki@samsung.com> - 2017-06-05 12:10 +0200
      Re: [PATCH] media: platform: s3c-camif: fix arguments position in  function call "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-06-05 18:00 +0200

csiph-web