Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1655785

Re: [WIP PATCH 0/4] Rework the unreliable LID switch exported by ACPI

Show all headers | View raw

On Thu, 2017-06-01 at 20:46 +0200, Benjamin Tissoires wrote:
> Hi,
> 
> Sending this as a WIP as it still need a few changes, but it mostly
> works as
> expected (still not fully compliant yet).
> 
> So this is based on Lennart's comment in [1]: if the LID state is not
> reliable,
> the kernel should not export the LID switch device as long as we are
> not sure
> about its state.
> 
> That is the basic idea, and here are some more general comments:
> Lv described the 5 cases in "RFC PATCH v3" regarding the LID switch.
> Let me rewrite them here (they are in patch 2):
> 
> 1. Some platforms send "open" ACPI notification to the OS and the
> event
>    arrive before the button driver is resumed;
> 2. Some platforms send "open" ACPI notification to the OS, but the
> event
>    arrives after the button driver is resumed, ex., Samsung N210+;
> 3. Some platforms never send an "open" ACPI notification to the OS,
> but
>    update the cached _LID return value to "open", and this update
> arrives
>    before the button driver is resumed;
> 4. Some platforms never send an "open" ACPI notification to the OS,
> but
>    update the cached _LID return value to "open", but this update
> arrives
>    after the button driver is resumed, ex., Surface Pro 3;
> 5. Some platforms never send an "open" ACPI notification to the OS,
> and
>    _LID ACPI method returns a value which stays to "close", ex.,
>    Surface Pro 1.

In which case does the Surface 3 lie? I believe we still needed your
"gpiolib-acpi: make sure we trigger the events at least once" patch to
make that one work.

Cheers

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[WIP PATCH 0/4] Rework the unreliable LID switch exported by ACPI Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2017-06-01 20:50 +0200
  [WIP PATCH 3/4] ACPI: button: Let input filter out the LID events Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2017-06-01 20:50 +0200
    RE: [WIP PATCH 3/4] ACPI: button: Let input filter out the LID  events "Zheng, Lv" <lv.zheng@intel.com> - 2017-06-05 06:30 +0200
      Re: [WIP PATCH 3/4] ACPI: button: Let input filter out the LID events Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2017-06-06 12:40 +0200
  Re: [WIP PATCH 0/4] Rework the unreliable LID switch exported by  ACPI Bastien Nocera <hadess@hadess.net> - 2017-06-01 23:50 +0200
    Re: [WIP PATCH 0/4] Rework the unreliable LID switch exported by ACPI Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2017-06-02 09:30 +0200
  RE: [WIP PATCH 0/4] Rework the unreliable LID switch exported by  ACPI "Zheng, Lv" <lv.zheng@intel.com> - 2017-06-05 04:30 +0200
  Re: [systemd-devel] [WIP PATCH 0/4] Rework the unreliable LID switch  exported by ACPI Lennart Poettering <mzxreary@0pointer.de> - 2017-06-07 10:00 +0200

csiph-web