Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1653953

[PATCH 1/5] x86: boot/copy, remove unused functions

Show all headers | View raw

copy_from_gs and copy_to_gs are unused in the boot code. They have
actually never been used -- they were always commented out since their
addition in 5be865661516 ("String-handling functions for the new x86
setup code.") in 2007. So remove them -- they can be restored from
history if need be.

Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: x86@kernel.org
---
 arch/x86/boot/copy.S | 20 --------------------
 1 file changed, 20 deletions(-)

diff --git a/arch/x86/boot/copy.S b/arch/x86/boot/copy.S
index 1eb7d298b47d..15d9f74b0008 100644
--- a/arch/x86/boot/copy.S
+++ b/arch/x86/boot/copy.S
@@ -65,23 +65,3 @@ GLOBAL(copy_to_fs)
 	popw	%es
 	retl
 ENDPROC(copy_to_fs)
-
-#if 0 /* Not currently used, but can be enabled as needed */
-GLOBAL(copy_from_gs)
-	pushw	%ds
-	pushw	%gs
-	popw	%ds
-	calll	memcpy
-	popw	%ds
-	retl
-ENDPROC(copy_from_gs)
-
-GLOBAL(copy_to_gs)
-	pushw	%es
-	pushw	%gs
-	popw	%es
-	calll	memcpy
-	popw	%es
-	retl
-ENDPROC(copy_to_gs)
-#endif
-- 
2.13.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/5] x86: boot/copy, remove unused functions Jiri Slaby <jslaby@suse.cz> - 2017-05-31 10:20 +0200
  [PATCH 3/5] x86_64: boot, extract efi_pe_entry from startup_64 Jiri Slaby <jslaby@suse.cz> - 2017-05-31 10:20 +0200
    Re: [PATCH 3/5] x86_64: boot, extract efi_pe_entry from startup_64 Matt Fleming <matt@codeblueprint.co.uk> - 2017-06-05 16:30 +0200
  [PATCH 2/5] x86_32: boot, extract efi_pe_entry from startup_32 Jiri Slaby <jslaby@suse.cz> - 2017-05-31 10:20 +0200
    Re: [PATCH 2/5] x86_32: boot, extract efi_pe_entry from startup_32 Matt Fleming <matt@codeblueprint.co.uk> - 2017-06-05 16:30 +0200
  [PATCH 5/5] x86: entry, use ENTRY instead of ALIGN+GLOBAL for stub32_clone Jiri Slaby <jslaby@suse.cz> - 2017-05-31 10:20 +0200
  [PATCH 4/5] x86: math-emu, add ENDPROC to functions Jiri Slaby <jslaby@suse.cz> - 2017-05-31 10:20 +0200
  [tip:x86/boot] x86/boot: Remove unused copy_*_gs() functions tip-bot for Jiri Slaby <tipbot@zytor.com> - 2017-06-05 11:20 +0200

csiph-web