Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1652803

Re: [PATCH v2] mm/oom_kill: count global and memory cgroup oom kills

From David Rientjes <rientjes@google.com>
Newsgroups linux.kernel
Subject Re: [PATCH v2] mm/oom_kill: count global and memory cgroup oom kills
Date 2017-05-30 06:40 +0200
Message-ID <tMH6N-2gc-3@gated-at.bofh.it> (permalink)
References <tKYbM-6XD-15@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Thu, 25 May 2017, Konstantin Khlebnikov wrote:

> diff --git a/mm/oom_kill.c b/mm/oom_kill.c
> index 04c9143a8625..dd30a045ef5b 100644
> --- a/mm/oom_kill.c
> +++ b/mm/oom_kill.c
> @@ -876,6 +876,11 @@ static void oom_kill_process(struct oom_control *oc, const char *message)
>  	/* Get a reference to safely compare mm after task_unlock(victim) */
>  	mm = victim->mm;
>  	mmgrab(mm);
> +
> +	/* Raise event before sending signal: reaper must see this */

How is the oom reaper involved here?

> +	count_vm_event(OOM_KILL);
> +	mem_cgroup_count_vm_event(mm, OOM_KILL);
> +
>  	/*
>  	 * We should send SIGKILL before setting TIF_MEMDIE in order to prevent
>  	 * the OOM victim from depleting the memory reserves from the user

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v2] mm/oom_kill: count global and memory cgroup oom kills Konstantin Khlebnikov <khlebnikov@yandex-team.ru> - 2017-05-25 12:30 +0200
  Re: [PATCH v2] mm/oom_kill: count global and memory cgroup oom  kills David Rientjes <rientjes@google.com> - 2017-05-30 06:40 +0200
    Re: [PATCH v2] mm/oom_kill: count global and memory cgroup oom kills Konstantin Khlebnikov <koct9i@gmail.com> - 2017-05-30 07:00 +0200
  Re: [PATCH v2] mm/oom_kill: count global and memory cgroup oom kills Michal Hocko <mhocko@kernel.org> - 2017-06-05 11:00 +0200
    Re: [PATCH v2] mm/oom_kill: count global and memory cgroup oom kills Konstantin Khlebnikov <khlebnikov@yandex-team.ru> - 2017-06-05 16:30 +0200

csiph-web