Re: linux-next: build failure after merge of the rcu tree

From	Joe Perches <joe@perches.com>
Newsgroups	linux.kernel
Subject	Re: linux-next: build failure after merge of the rcu tree
Date	2017-05-30 04:30 +0200
Message-ID	<tMF4Z-PL-3@gated-at.bofh.it> (permalink)
References	<tMm2l-4il-1@gated-at.bofh.it> <tMAf0-5J1-13@gated-at.bofh.it> <tMEsi-cb-1@gated-at.bofh.it> <tMEBX-go-3@gated-at.bofh.it> <tMEVj-LL-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, 2017-05-29 at 19:14 -0700, Paul E. McKenney wrote:
> On Mon, May 29, 2017 at 06:54:26PM -0700, Joe Perches wrote:
> > On Tue, 2017-05-30 at 11:40 +1000, Stephen Rothwell wrote:
> > > Hi Paul,
> > > 
> > > > On Mon, 29 May 2017 14:15:05 -0700 "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> wrote:
> > > > 
> > > > Anyone see any other options?
> > 
> > My preferred option would be removing pr_fmt
> > and adding a couple new macros.
> 
> Not sure how to evaluate yours and Stephen's changes, but I reverted my
> conversion to a macro based on the hope that something good will come
> of this effort.  ;-)

Stephen's suggestion makes the format and arguments
have an apparent mismatch.  What I suggested hides
the "module %s: ", mod->name bit in the macros (like
the older pr_fmt use), allows anyone else to #define
pr_fmt to taste, and keeps the format and arguments in
agreement.

Thread

linux-next: build failure after merge of the rcu tree Stephen Rothwell <sfr@canb.auug.org.au> - 2017-05-29 08:10 +0200
  Re: linux-next: build failure after merge of the rcu tree "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2017-05-29 23:20 +0200
    Re: linux-next: build failure after merge of the rcu tree Stephen Rothwell <sfr@canb.auug.org.au> - 2017-05-30 03:50 +0200
      Re: linux-next: build failure after merge of the rcu tree Joe Perches <joe@perches.com> - 2017-05-30 04:00 +0200
        Re: linux-next: build failure after merge of the rcu tree "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2017-05-30 04:20 +0200
          Re: linux-next: build failure after merge of the rcu tree Joe Perches <joe@perches.com> - 2017-05-30 04:30 +0200
            Re: linux-next: build failure after merge of the rcu tree Stephen Rothwell <sfr@canb.auug.org.au> - 2017-05-30 05:20 +0200
    Re: linux-next: build failure after merge of the rcu tree Michael Ellerman <mpe@ellerman.id.au> - 2017-05-30 06:20 +0200
      Re: linux-next: build failure after merge of the rcu tree "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2017-06-02 20:00 +0200

csiph-web