Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1652004
| From | David Miller <davem@davemloft.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH net-next] net: dsa: mv88e6xxx: handle SERDES error appropriately |
| Date | 2017-05-28 01:00 +0200 |
| Message-ID | <tLSQF-1Ow-3@gated-at.bofh.it> (permalink) |
| References | <tLyIm-4Vw-135@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
From: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Date: Fri, 26 May 2017 18:02:42 -0400
> mv88e6xxx_serdes_power returns an error, so no need to print an error
> message inside of it. Rather print it in its caller when the error is
> ignored, which is in the mv88e6xxx_port_disable void function.
>
> Catch and return its error in the counterpart mv88e6xxx_port_enable.
>
> Fixes: 04aca9938255 ("dsa: mv88e6xxx: Enable/Disable SERDES on port enable/disable")
> Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Applied, thanks.
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH net-next] net: dsa: mv88e6xxx: handle SERDES error appropriately Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-05-27 03:30 +0200 Re: [PATCH net-next] net: dsa: mv88e6xxx: handle SERDES error appropriately David Miller <davem@davemloft.net> - 2017-05-28 01:00 +0200
csiph-web