Re: [PATCH v3] ext4: fix quota charging for shared xattr blocks

From	Theodore Ts'o <tytso@mit.edu>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3] ext4: fix quota charging for shared xattr blocks
Date	2017-05-25 00:30 +0200
Message-ID	<tKMX0-8aU-15@gated-at.bofh.it> (permalink)
References	<tKAsP-ma-39@gated-at.bofh.it> <tKCNX-1KT-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, May 24, 2017 at 04:35:19AM -0700, Tahsin Erdogan wrote:
> ext4_xattr_block_set() calls dquot_alloc_block() to charge for an xattr
> block when new references are made. However if dquot_initialize() hasn't
> been called on an inode, request for charging is effectively ignored
> because ext4_inode_info->i_dquot is not initialized yet.
> 
> Add dquot_initialize() to call paths that lead to ext4_xattr_block_set().
> 
> Signed-off-by: Tahsin Erdogan <tahsin@google.com>
> Reviewed-by: Jan Kara <jack@suse.cz>

Applied, thanks.

					- Ted

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] ext4: fix quota charging for shared xattr blocks Tahsin Erdogan <tahsin@google.com> - 2017-05-23 05:10 +0200
  Re: [PATCH] ext4: fix quota charging for shared xattr blocks Jan Kara <jack@suse.cz> - 2017-05-23 10:20 +0200
    [PATCH v2] ext4: fix quota charging for shared xattr blocks Tahsin Erdogan <tahsin@google.com> - 2017-05-24 01:10 +0200
      Re: [PATCH v2] ext4: fix quota charging for shared xattr blocks Jan Kara <jack@suse.cz> - 2017-05-24 11:10 +0200
        [PATCH v3] ext4: fix quota charging for shared xattr blocks Tahsin Erdogan <tahsin@google.com> - 2017-05-24 13:40 +0200
          Re: [PATCH v3] ext4: fix quota charging for shared xattr blocks Theodore Ts'o <tytso@mit.edu> - 2017-05-25 00:30 +0200

csiph-web