Re: [PATCH] zlib: Put get_unaligned16() inside #ifdef block

From	Matthias Kaehlcke <mka@chromium.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] zlib: Put get_unaligned16() inside #ifdef block
Date	2017-05-23 00:20 +0200
Message-ID	<tK3Qd-30F-3@gated-at.bofh.it> (permalink)
References	<tK2Ua-2m2-31@gated-at.bofh.it> <tK3dv-2wK-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Andrew,

El Mon, May 22, 2017 at 02:39:25PM -0700 Andrew Morton ha dit:

> On Mon, 22 May 2017 14:13:26 -0700 Matthias Kaehlcke <mka@chromium.org> wrote:
> 
> > The function is not used when CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS=y.
> > Adding the #ifdef fixes the following warning when building with clang:
> > 
> > lib/zlib_inflate/inffast.c:31:1: error: unused function 'get_unaligned16'
> >     [-Werror,-Wunused-function]
> > 
> > ...
> >
> > --- a/lib/zlib_inflate/inffast.c
> > +++ b/lib/zlib_inflate/inffast.c
> > @@ -26,6 +26,7 @@ union uu {
> >  	unsigned char b[2];
> >  };
> >  
> > +#ifndef CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS
> >  /* Endian independed version */
> >  static inline unsigned short
> >  get_unaligned16(const unsigned short *p)
> > @@ -37,6 +38,7 @@ get_unaligned16(const unsigned short *p)
> >  	mm.b[1] = b[1];
> >  	return mm.us;
> >  }
> > +#endif
> >  
> >  #ifdef POSTINC
> >  #  define OFF 0
> 
> Do we really want to mucky up the source code to keep clang happy?  gcc
> won't warn about an unused static inline.  Can we configure clang to do
> the same?

To my knowledge there is no option to tell clang to behave like gcc in
this aspect.

On the positive side the number of instances is relatively limited, at
least for defconfig and my custom configs. In most cases it is enough
with adding __maybe_unused, which is already widely used in the kernel.

Personally I think it is useful to be warned about unused functions in
.c files, regardless of whether the function is inline or not.

Thread

[PATCH] zlib: Put get_unaligned16() inside #ifdef block Matthias Kaehlcke <mka@chromium.org> - 2017-05-22 23:20 +0200
  Re: [PATCH] zlib: Put get_unaligned16() inside #ifdef block Andrew Morton <akpm@linux-foundation.org> - 2017-05-22 23:40 +0200
    Re: [PATCH] zlib: Put get_unaligned16() inside #ifdef block Matthias Kaehlcke <mka@chromium.org> - 2017-05-23 00:20 +0200
  Re: [PATCH] zlib: Put get_unaligned16() inside #ifdef block Christoph Hellwig <hch@infradead.org> - 2017-05-23 09:40 +0200
    Re: [PATCH] zlib: Put get_unaligned16() inside #ifdef block Matthias Kaehlcke <mka@chromium.org> - 2017-05-23 20:10 +0200

csiph-web