Re: [PATCH 0/3] stmmac: pci: Refactor DMI probing

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH 0/3] stmmac: pci: Refactor DMI probing
Date	2017-05-22 20:30 +0200
Message-ID	<tK0fD-HF-5@gated-at.bofh.it> (permalink)
References	<tJTxw-50U-13@gated-at.bofh.it> <tJYxc-83k-25@gated-at.bofh.it> <tJZ0e-8sT-31@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Jan Kiszka <jan.kiszka@siemens.com>
Date: Mon, 22 May 2017 19:06:07 +0200

> On 2017-05-22 18:35, David Miller wrote:
>> From: Jan Kiszka <jan.kiszka@siemens.com>
>> Date: Mon, 22 May 2017 13:12:06 +0200
>> 
>>> Some cleanups of the way we probe DMI platforms in the driver. Reduces
>>> a bit of open-coding and makes the logic easier reusable for any
>>> potential DMI platform != Quark.
>>>
>>> Tested on IOT2000 and Galileo Gen2.
>> 
>> This doesn't compile:
>> 
>> drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c:285:3: error: initializer element is not computable at load time
>>    (kernel_ulong_t)&stmmac_default_setup,
>>    ^
>> drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c:285:3: note: (near initialization for ‘stmmac_id_table[0].class’)
>> drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c:289:3: error: initializer element is not computable at load time
>>    (kernel_ulong_t)&stmmac_default_setup,
>>    ^
>> drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c:289:3: note: (near initialization for ‘stmmac_id_table[1].class’)
>> scripts/Makefile.build:302: recipe for target 'drivers/net/ethernet/stmicro/stmmac/stmmac_pci.o' failed
>> make[5]: *** [drivers/net/ethernet/stmicro/stmmac/stmmac_pci.o] Error 1
>> 
> 
> Hmm. Which arch is this?

x86_64, allmodconfig

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] stmmac: pci: Refactor DMI probing Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-22 13:20 +0200
  Re: [PATCH 0/3] stmmac: pci: Refactor DMI probing David Miller <davem@davemloft.net> - 2017-05-22 18:40 +0200
    Re: [PATCH 0/3] stmmac: pci: Refactor DMI probing Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-22 19:10 +0200
      Re: [PATCH 0/3] stmmac: pci: Refactor DMI probing David Miller <davem@davemloft.net> - 2017-05-22 20:30 +0200

csiph-web