Re: [PATCH v2 1/7] kernel/locking: Fix compile error with qrwlock.c

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 1/7] kernel/locking: Fix compile error with qrwlock.c
Date	2017-05-22 21:10 +0200
Message-ID	<tK0Sl-19u-7@gated-at.bofh.it> (permalink)
References	<tJ0hH-1Ey-3@gated-at.bofh.it> <tJ0hI-1Ey-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Babu Moger <babu.moger@oracle.com>
Date: Fri, 19 May 2017 18:16:55 -0600

> Some architectures use the following guard in include file
>  "asm/spinlock_types.h" to discourage including the file directly.
> 
> Saw these compile errors on SPARC when queued rwlock feature is enabled.
> 
>   CC      kernel/locking/qrwlock.o
> In file included from ./include/asm-generic/qrwlock_types.h:5,
>                  from ./arch/sparc/include/asm/qrwlock.h:4,
>                  from kernel/locking/qrwlock.c:24:
> ./arch/sparc/include/asm/spinlock_types.h:5:3: error:
>         #error "please don't include this file directly"
> 
> Re-arrange the includes in qrwlock_types.h and include spinlock.h
> in qrwlock.c to fix it.
> 
> Also will be removing this stanza from SPARC. Stay tuned.
> 
> Signed-off-by: Babu Moger <babu.moger@oracle.com>
> Reviewed-by: Håkon Bugge <haakon.bugge@oracle.com>
> Reviewed-by: Jane Chu <jane.chu@oracle.com>
> Reviewed-by: Shannon Nelson <shannon.nelson@oracle.com>
> Reviewed-by: Vijay Kumar <vijay.ac.kumar@oracle.com>

In my feedback I said to remove that check from
sparc's asm/spinlock_types.h header.

Which you do in patch #2

But that means this patch #1 here is no longer necessary, since we
conform to the hearder scheme used by other architectures using queued
locks.

So please remove this patch from the series.

Thank you.

Thread

[PATCH v2 1/7] kernel/locking: Fix compile error with qrwlock.c Babu Moger <babu.moger@oracle.com> - 2017-05-20 02:20 +0200
  Re: [PATCH v2 1/7] kernel/locking: Fix compile error with qrwlock.c David Miller <davem@davemloft.net> - 2017-05-22 21:10 +0200
    Re: [PATCH v2 1/7] kernel/locking: Fix compile error with qrwlock.c Babu Moger <babu.moger@oracle.com> - 2017-05-23 00:00 +0200
      Re: [PATCH v2 1/7] kernel/locking: Fix compile error with qrwlock.c David Miller <davem@davemloft.net> - 2017-05-23 01:10 +0200

csiph-web