Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1646196

[PATCH 4/5] fsl_hypervisor: Use kcalloc() in ioctl_memcpy()

Show all headers | View raw

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 20 May 2017 20:15:57 +0200

* A multiplication for the size determination of a memory allocation
  indicated that an array data structure should be processed.
  Thus use the corresponding function "kcalloc".

  This issue was detected by using the Coccinelle software.

* Replace the specification of a data type by a pointer dereference
  to make the corresponding size determination a bit safer according to
  the Linux coding style convention.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/virt/fsl_hypervisor.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/virt/fsl_hypervisor.c b/drivers/virt/fsl_hypervisor.c
index 9e881dc29c6b..4031632b8c9d 100644
--- a/drivers/virt/fsl_hypervisor.c
+++ b/drivers/virt/fsl_hypervisor.c
@@ -223,5 +223,5 @@ static long ioctl_memcpy(struct fsl_hv_ioctl_memcpy __user *p)
 	 * 'pages' is an array of struct page pointers that's initialized by
 	 * get_user_pages().
 	 */
-	pages = kzalloc(num_pages * sizeof(struct page *), GFP_KERNEL);
+	pages = kcalloc(num_pages, sizeof(*pages), GFP_KERNEL);
 	if (!pages) {
-- 
2.13.0

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/5] fsl_hypervisor: Adjustments for two function  implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-20 21:10 +0200
  [PATCH 3/5] fsl_hypervisor: Return the success indication only as a  constant in fsl_hv_open() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-20 21:20 +0200
  [PATCH 5/5] fsl_hypervisor: Delete error messages for failed memory  allocations in ioctl_memcpy() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-20 21:20 +0200
  [PATCH 4/5] fsl_hypervisor: Use kcalloc() in ioctl_memcpy() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-20 21:20 +0200
  [PATCH 1/5] fsl_hypervisor: Improve a size determination in  fsl_hv_open() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-20 21:20 +0200
  [PATCH 2/5] fsl_hypervisor: Delete an error message for a failed  memory allocation in fsl_hv_open() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-20 21:20 +0200

csiph-web