Groups > linux.kernel > #1641930

Re: [PATCH v3] Add "shutdown" to "struct class".

From	Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3] Add "shutdown" to "struct class".
Date	2017-05-15 19:50 +0200
Message-ID	<tHsi6-2M0-7@gated-at.bofh.it> (permalink)
References	<tHs8p-2IK-3@gated-at.bofh.it> <tHs8q-2IK-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, May 15, 2017 at 10:39:08AM -0700, Josh Zimmerman wrote:
> (Continuing thread from patch v1)
> > > On Sat, May 13, 2017 at 12:43:11PM +0000, Winkler, Tomas wrote:
> > > > > The TPM class has some common shutdown code that must be executed
> > > > > for all drivers. This adds some needed functionality for that
> > > >
> > > > The issue with this is, that on some platforms the only storage can be
> > > > eMMC and TPM is using it,. It has to be ensured that the storage
> > > > device won't go down before TPM2_shutdown is called.  And there is no
> > > > direct device hierarchy to ensure an orderly shutdown.
> > >
> > > Something will have to use the new device links stuff to define that
> > > dependency, but that seems unrelated to this patch?
> >
> >
> > Yep, it's not directly related to this specific patch, this is more relevant particularly to TPM2_shutdown.
> 
> Jason, do you want me to do that in my patch on the tpmdd-devel list?
> If so, mind giving me a documentation pointer or two? I'm not familiar
> with this area.

No.. Ordering power management events is something someone with
knowledge of the specific emmc platform is going to have to tackle..
It isn't really a core problem, platform specific code will have to
setup the needed device links to order power management properly..

Jason

Thread

[PATCH v3] Add "shutdown" to "struct class". Josh Zimmerman <joshz@google.com> - 2017-05-15 19:40 +0200
  Re: [PATCH v3] Add "shutdown" to "struct class". Josh Zimmerman <joshz@google.com> - 2017-05-15 19:40 +0200
    Re: [PATCH v3] Add "shutdown" to "struct class". Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2017-05-15 19:50 +0200
      RE: [PATCH v3] Add "shutdown" to "struct class". "Winkler, Tomas" <tomas.winkler@intel.com> - 2017-05-15 22:50 +0200
        Re: [PATCH v3] Add "shutdown" to "struct class". Josh Zimmerman <joshz@google.com> - 2017-05-18 17:30 +0200

csiph-web