Re: [PATCH 3/3] Fix ERROR: code indent should use tabs where possible

From	"Michael S. Tsirkin" <mst@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/3] Fix ERROR: code indent should use tabs where possible
Date	2017-05-15 05:10 +0200
Message-ID	<tHeyt-2hV-1@gated-at.bofh.it> (permalink)
References	<tH5Ye-4E8-5@gated-at.bofh.it> <tH5Ye-4E8-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sun, May 14, 2017 at 07:51:30PM +0200, Maciek Fijalkowski wrote:
> From: Maciej Fijalkowski <macfij7@wp.pl>
> 
> Signed-off-by: Maciej Fijalkowski <macfij7@wp.pl>


Acked-by: Michael S. Tsirkin <mst@redhat.com>

But you really want to fix the subject. Make it less verbose
drop upper case and add info about module. Something like:

virtio_net: coding style fix: use tabs for indent

Also, you misspelled Jason's email.

> ---
>  drivers/net/virtio_net.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> index 6c8170c..5d71e9f 100644
> --- a/drivers/net/virtio_net.c
> +++ b/drivers/net/virtio_net.c
> @@ -2717,7 +2717,7 @@ static __init int virtio_net_driver_init(void)
>  	if (ret)
>  		goto err_dead;
>  
> -        ret = register_virtio_driver(&virtio_net_driver);
> +	ret = register_virtio_driver(&virtio_net_driver);
>  	if (ret)
>  		goto err_virtio;
>  	return 0;
> -- 
> 2.4.11

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 3/3] Fix ERROR: code indent should use tabs where possible Maciek Fijalkowski <macfij7@wp.pl> - 2017-05-14 20:00 +0200
  Re: [PATCH 3/3] Fix ERROR: code indent should use tabs where possible "Michael S. Tsirkin" <mst@redhat.com> - 2017-05-15 05:10 +0200

csiph-web