Re: [PATCH V2 2/6] tty: serial: lpuart: add little endian 32 bit register support

From	Dong Aisheng <dongas86@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH V2 2/6] tty: serial: lpuart: add little endian 32 bit register support
Date	2017-05-17 05:30 +0200
Message-ID	<tHXOW-69n-5@gated-at.bofh.it> (permalink)
References	<tHoo9-lZ-11@gated-at.bofh.it> <tHoo9-lZ-13@gated-at.bofh.it> <tHoo9-lZ-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, May 15, 2017 at 04:36:25PM +0300, Andy Shevchenko wrote:
> On Mon, May 15, 2017 at 10:48 AM, Dong Aisheng <aisheng.dong@nxp.com> wrote:
> > It's based on the exist lpuart32 read/write implementation.
> 
> Same as per previous comment (perhaps not in other UART driver, but
> some might have been using device property for that.
> 

The reason why we do that is: a) we don't want to make a churn on the
exist users. b) it's not really necessary to use dt property
when we already have a soc_data as it has no much benefit but introduce
overhead.

Regards
Dong Aisheng

> 
> -- 
> With Best Regards,
> Andy Shevchenko

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH V2 2/6] tty: serial: lpuart: add little endian 32 bit  register support Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-15 15:40 +0200
  Re: [PATCH V2 2/6] tty: serial: lpuart: add little endian 32 bit  register support Dong Aisheng <dongas86@gmail.com> - 2017-05-17 05:30 +0200

csiph-web