Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1642891

Re: [patch V2 17/17] sched: Enable might_sleep() and smp_processor_id() checks early

From Steven Rostedt <rostedt@goodmis.org>
Newsgroups linux.kernel
Subject Re: [patch V2 17/17] sched: Enable might_sleep() and smp_processor_id() checks early
Date 2017-05-17 01:00 +0200
Message-ID <tHTBD-3kx-3@gated-at.bofh.it> (permalink)
References <tHPRn-M2-5@gated-at.bofh.it> <tHPRo-M2-39@gated-at.bofh.it> <tHQaJ-18a-5@gated-at.bofh.it> <tHTrX-3gi-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Wed, 17 May 2017 00:46:37 +0200 (CEST)
Thomas Gleixner <tglx@linutronix.de> wrote:


> > > --- a/lib/smp_processor_id.c
> > > +++ b/lib/smp_processor_id.c
> > > @@ -28,7 +28,7 @@ notrace static unsigned int check_preemp
> > >  	/*
> > >  	 * It is valid to assume CPU-locality during early bootup:
> > >  	 */
> > > -	if (system_state != SYSTEM_RUNNING)
> > > +	if (system_state < SYSTEM_SCHEDULING)  
> > 
> > Do we want to ignore halting or rebooting too?  
> 
> I don't think so. After setting those states, interesting stuff like
> device_shutdown() gets invoked. We want the coverage there.

Then I'd suggest that you update the change log, as this patch also
adds coverage to those states as well.

-- Steve

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[patch V2 17/17] sched: Enable might_sleep() and smp_processor_id()  checks early Thomas Gleixner <tglx@linutronix.de> - 2017-05-16 21:00 +0200
  Re: [patch V2 17/17] sched: Enable might_sleep() and  smp_processor_id() checks early Steven Rostedt <rostedt@goodmis.org> - 2017-05-16 21:20 +0200
    Re: [patch V2 17/17] sched: Enable might_sleep() and smp_processor_id()  checks early Thomas Gleixner <tglx@linutronix.de> - 2017-05-17 00:50 +0200
      Re: [patch V2 17/17] sched: Enable might_sleep() and  smp_processor_id() checks early Steven Rostedt <rostedt@goodmis.org> - 2017-05-17 01:00 +0200
  Re: [patch V2 17/17] sched: Enable might_sleep() and  smp_processor_id() checks early Mark Rutland <mark.rutland@arm.com> - 2017-05-17 13:10 +0200
  [tip:sched/core] sched/core: Enable might_sleep() and  smp_processor_id() checks early tip-bot for Thomas Gleixner <tipbot@zytor.com> - 2017-05-23 11:10 +0200

csiph-web