Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1640536

Re: [PATCH] net: ipv6: Truncate single route when it doesn't fit into dump buffer.

From David Miller <davem@davemloft.net>
Newsgroups linux.kernel
Subject Re: [PATCH] net: ipv6: Truncate single route when it doesn't fit into dump buffer.
Date 2017-05-12 17:30 +0200
Message-ID <tGkFX-6vb-5@gated-at.bofh.it> (permalink)
References <tGgVH-3Lp-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


From: Jan Moskyto Matejka <mq@ucw.cz>
Date: Fri, 12 May 2017 13:15:10 +0200

> -int rt6_dump_route(struct rt6_info *rt, void *p_arg);
> +int rt6_dump_route(struct rt6_info *rt, void *p_arg, int truncate);

Please use "bool" and "true"/"false" for boolean values.

What does ipv4 do in this situation?

I'm hesitant to be OK with adding a new nlmsg flag just for this case
if we solve this problem differently and using existing mechanisms
elsewhere.

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] net: ipv6: Truncate single route when it doesn't fit into dump buffer. Jan Moskyto Matejka <mq@ucw.cz> - 2017-05-12 13:30 +0200
  Re: [PATCH] net: ipv6: Truncate single route when it doesn't fit  into dump buffer. David Miller <davem@davemloft.net> - 2017-05-12 17:30 +0200
    Re: [PATCH] net: ipv6: Truncate single route when it doesn't fit into  dump buffer. David Ahern <dsahern@gmail.com> - 2017-05-12 19:30 +0200
      Re: [PATCH] net: ipv6: Truncate single route when it doesn't fit  into dump buffer. David Miller <davem@davemloft.net> - 2017-05-12 19:40 +0200
      Re: [PATCH] net: ipv6: Truncate single route when it doesn't fit  into dump buffer. Jan Moskyto Matejka <mq@jmq.cz> - 2017-05-12 23:50 +0200
    Re: [PATCH] net: ipv6: Truncate single route when it doesn't fit  into dump buffer. Jan Moskyto Matejka <mq@jmq.cz> - 2017-05-12 23:50 +0200

csiph-web