Re: [PATCH] staging: rtl8192u: Fix type mismatch warnings reported by sparse

From	Greg KH <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] staging: rtl8192u: Fix type mismatch warnings reported by sparse
Date	2017-05-12 11:10 +0200
Message-ID	<tGeKd-2eI-9@gated-at.bofh.it> (permalink)
References	<tF9Wi-8nt-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, May 09, 2017 at 03:17:56PM +0530, suniel.spartan@gmail.com wrote:
> From: Suniel Mahesh <suniel.spartan@gmail.com>
> 
> The function Mk16_le() is calling le16_to_cpu()
> internally. le16_to_cpu() takes an argument of type (__le *)
> but the argument passed is of type (u16 *). Fixed it by passing
> the correct argument type.
> 
> Signed-off-by: Suniel Mahesh <suniel.spartan@gmail.com>
> ---
>  .../rtl8192u/ieee80211/ieee80211_crypt_tkip.c      | 22 +++++++++++-----------
>  1 file changed, 11 insertions(+), 11 deletions(-)

Is this a resend?

> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c
> index 5039172..11ddf30 100644
> --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c
> +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c
> @@ -172,7 +172,7 @@ static inline u16 Mk16(u8 hi, u8 lo)
>  }
>  
>  
> -static inline u16 Mk16_le(u16 *v)
> +static inline u16 Mk16_le(__le16 *v)
>  {
>  	return le16_to_cpu(*v);
>  }

Just use the real function here and delete this "odd" one.

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] staging: rtl8192u: Fix type mismatch warnings reported by sparse suniel.spartan@gmail.com - 2017-05-09 11:50 +0200
  Re: [PATCH] staging: rtl8192u: Fix type mismatch warnings reported  by sparse Greg KH <gregkh@linuxfoundation.org> - 2017-05-12 11:10 +0200

csiph-web