Re: [PATCH v2 5/7] drm/ltdc: Use the panel-bridge helper.

From	Boris Brezillon <boris.brezillon@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 5/7] drm/ltdc: Use the panel-bridge helper.
Date	2017-05-12 10:20 +0200
Message-ID	<tGdXP-1DJ-1@gated-at.bofh.it> (permalink)
References	<tG1ah-1ut-3@gated-at.bofh.it> <tG1ai-1ut-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, 11 May 2017 11:31:26 -0700
Eric Anholt <eric@anholt.net> wrote:

> Another 100 lines of boilerplate gone.  Bridges aren't supported yet,
> but will be trivial to add later.
> 
> Signed-off-by: Eric Anholt <eric@anholt.net>
> ---
> 

[...]

> @@ -1082,28 +993,13 @@ int ltdc_load(struct drm_device *ddev)
>  
>  	DRM_INFO("ltdc hw version 0x%08x - ready\n", ldev->caps.hw_version);
>  
> -	if (ldev->panel) {
> +	if (ldev->bridge) {
>  		encoder = ltdc_rgb_encoder_create(ddev);
>  		if (!encoder) {
>  			DRM_ERROR("Failed to create RGB encoder\n");
>  			ret = -EINVAL;
>  			goto err;
>  		}

You should have a call to drm_bridge_attach() somewhere, otherwise your
panel (and its connector) will not be registered.

> -
> -		connector = ltdc_rgb_connector_create(ddev);
> -		if (!connector) {
> -			DRM_ERROR("Failed to create RGB connector\n");
> -			ret = -EINVAL;
> -			goto err;
> -		}
> -
> -		ret = drm_mode_connector_attach_encoder(connector, encoder);
> -		if (ret) {
> -			DRM_ERROR("Failed to attach connector to encoder\n");
> -			goto err;
> -		}
> -
> -		drm_panel_attach(ldev->panel, connector);
>  	}
>

Thread

[PATCH v2 1/7] drm/bridge: Refactor out the panel wrapper from the lvds-encoder bridge. Eric Anholt <eric@anholt.net> - 2017-05-11 20:40 +0200
  [PATCH v2 5/7] drm/ltdc: Use the panel-bridge helper. Eric Anholt <eric@anholt.net> - 2017-05-11 20:40 +0200
    Re: [PATCH v2 5/7] drm/ltdc: Use the panel-bridge helper. Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-05-12 10:20 +0200
  [PATCH v2 3/7] drm/vc4: Switch DPI to using the panel-bridge helper. Eric Anholt <eric@anholt.net> - 2017-05-11 20:40 +0200
    Re: [PATCH v2 3/7] drm/vc4: Switch DPI to using the panel-bridge  helper. Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-05-12 10:10 +0200
  [PATCH v2 2/7] drm/vc4: Switch DSI to the panel-bridge layer, and support bridges. Eric Anholt <eric@anholt.net> - 2017-05-11 20:40 +0200
    Re: [PATCH v2 2/7] drm/vc4: Switch DSI to the panel-bridge layer,  and support bridges. Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-05-12 10:10 +0200
  Re: [PATCH v2 1/7] drm/bridge: Refactor out the panel wrapper from  the lvds-encoder bridge. Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-05-12 09:40 +0200
  Re: [PATCH v2 1/7] drm/bridge: Refactor out the panel wrapper from  the lvds-encoder bridge. Archit Taneja <architt@codeaurora.org> - 2017-05-12 12:20 +0200

csiph-web