Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1640873

Re: [PATCH v1] samples/bpf: Add a .gitignore for binaries

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On 13/02/2017 02:43, David Ahern wrote:
> On 2/12/17 2:23 PM, Mickaël Salaün wrote:
>> diff --git a/samples/bpf/.gitignore b/samples/bpf/.gitignore
>> new file mode 100644
>> index 000000000000..a7562a5ef4c2
>> --- /dev/null
>> +++ b/samples/bpf/.gitignore
>> @@ -0,0 +1,32 @@
>> +fds_example
>> +lathist
> 
> ...
> 
> Listing each target is going to be a PITA to maintain. It would be
> better to put targets into a build directory (bin?) and ignore the
> directory.
> 

It would require a lot of modifications to the Makefile and more
complexity. It seems much more simple for everyone to stick to a simple
gitignore file easily maintainable:
$ awk '$1 == "hostprogs-y" { print $3 }' < Makefile > .gitignore

Alexei, Daniel, what do you think about this? Do you want me to send a
v2 with the new tests?

 Mickaël

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v1] samples/bpf: Add a .gitignore for binaries Mickaël Salaün <mic@digikod.net> - 2017-05-13 12:40 +0200
  Re: [PATCH v1] samples/bpf: Add a .gitignore for binaries David Ahern <dsahern@gmail.com> - 2017-05-17 01:30 +0200
    Re: [PATCH v1] samples/bpf: Add a .gitignore for binaries Alexander Alemayhu <alexander@alemayhu.com> - 2017-05-17 10:20 +0200
      Re: [PATCH v1] samples/bpf: Add a .gitignore for binaries David Ahern <dsahern@gmail.com> - 2017-05-18 22:10 +0200

csiph-web