Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1638273

Re: get/put_cpu() usage in block/blk-mq.c

From Mike Galbraith <efault@gmx.de>
Newsgroups linux.kernel
Subject Re: get/put_cpu() usage in block/blk-mq.c
Date 2017-05-09 18:30 +0200
Message-ID <tFgbo-4bu-23@gated-at.bofh.it> (permalink)
References (2 earlier) <tFeVY-3qX-25@gated-at.bofh.it> <tFfyG-3F4-7@gated-at.bofh.it> <tFfyG-3F4-9@gated-at.bofh.it> <tFfyG-3F4-5@gated-at.bofh.it> <tFgbo-4bu-25@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Tue, 2017-05-09 at 09:45 -0600, Jens Axboe wrote:

> > > > > > Is it from this_cpu_ptr() in blk_stat_add()?
> > > > > 
> > > > > Yeah.
> > > > 
> > > > So why is this complaining, doesn't rcu_read_lock() disable
> > > > preemption?
> > > 
> > > Ah, I guess it doesn't if PREEMPT_RCU is set. How about the
> > > below?
> > 
> > Should do it.  I was about to run LTP (where it turned up) again
> > anyway, I'll add this.  No news is good news, what you should hear.
> 
> Thanks, let me know, so I can add your tested-by (or whatever you
> prefer).

Sure, but s/get_cpu_var/get_cpu_ptr first.

	-MIke

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

get/put_cpu() usage in block/blk-mq.c Mike Galbraith <efault@gmx.de> - 2017-05-09 08:10 +0200
  Re: get/put_cpu() usage in block/blk-mq.c Mike Galbraith <efault@gmx.de> - 2017-05-09 17:10 +0200
    Re: get/put_cpu() usage in block/blk-mq.c Mike Galbraith <efault@gmx.de> - 2017-05-09 17:50 +0200
      Re: get/put_cpu() usage in block/blk-mq.c Mike Galbraith <efault@gmx.de> - 2017-05-09 18:30 +0200
        Re: get/put_cpu() usage in block/blk-mq.c Mike Galbraith <efault@gmx.de> - 2017-05-09 19:00 +0200

csiph-web