Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1638115

Re: [PATCH] asm-generic/io.h: remove unnecessary #include of <linux/vmalloc.h>

Show all headers | View raw

On 2017-05-09 at 11:02:07 +0200, Michal Hocko <mhocko@kernel.org> wrote:
> On Tue 09-05-17 10:50:45, Tobias Klauser wrote:
> > After commit 1f5307b1e094 ("mm, vmalloc: properly track vmalloc users")
> > the build for ARCH=nios2 fails with:
> > 
> > In file included from ./include/asm-generic/io.h:767:0,
> >   		 from ./arch/nios2/include/asm/io.h:61,
> > 		 from ./include/linux/io.h:25,
> > 		 from ./arch/nios2/include/asm/pgtable.h:18,
> > 		 from ./include/linux/mm.h:70,
> > 		 from ./include/linux/pid_namespace.h:6,
> > 		 from ./include/linux/ptrace.h:9,
> > 		 from ./arch/nios2/include/uapi/asm/elf.h:23,
> > 		 from ./arch/nios2/include/asm/elf.h:22,
> > 		 from ./include/linux/elf.h:4,
> > 		 from ./include/linux/module.h:15,
> > 		 from init/main.c:16:
> > ./include/linux/vmalloc.h: In function '__vmalloc_node_flags':
> > ./include/linux/vmalloc.h:99:40: error: 'PAGE_KERNEL' undeclared (first use in this function); did you mean 'GFP_KERNEL'?
> > 
> > which is due to the newly added #include <asm/pgtable.h>, which on nios2
> > includes <linux/io.h> and thus <asm/io.h> and <asm-generic/io.h> which
> > again includes <linux/vmalloc.h>.
> > 
> > It turns out the #include <linux/vmalloc.h> in <asm-generic/io.h> isn't
> > necessary at all since none of it definitions are used there, so remove
> > it alltogether.
> 
> Thanks for your fix but I have already posted a different one [1] which
> doesn't include pgtable.h because this turned out to be a problem on
> m68k already. I am just waiting for Andrew to drop the previous patch
> and replace it with the one pointed out.
> 
> [1] http://lkml.kernel.org/r/20170503063750.GC1236@dhcp22.suse.cz

Thanks for the info. Though it looks like your original patch already
made it into Linus' tree as commit 1f5307b1e094.

As for my patch, please disregard - it lead to several build regressions
with the kernel build bot.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] asm-generic/io.h: remove unnecessary #include of <linux/vmalloc.h> Tobias Klauser <tklauser@distanz.ch> - 2017-05-09 11:00 +0200
  Re: [PATCH] asm-generic/io.h: remove unnecessary #include of  <linux/vmalloc.h> Michal Hocko <mhocko@kernel.org> - 2017-05-09 11:10 +0200
    Re: [PATCH] asm-generic/io.h: remove unnecessary #include of  <linux/vmalloc.h> Tobias Klauser <tklauser@distanz.ch> - 2017-05-09 15:20 +0200
      Re: [PATCH] asm-generic/io.h: remove unnecessary #include of  <linux/vmalloc.h> Michal Hocko <mhocko@kernel.org> - 2017-05-09 15:50 +0200
  Re: [PATCH] asm-generic/io.h: remove unnecessary #include of  <linux/vmalloc.h> kbuild test robot <lkp@intel.com> - 2017-05-09 14:10 +0200

csiph-web