Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1638083

Re: [PATCH] net: wireless: ath: ath10k: remove unnecessary code

From Kalle Valo <kvalo@qca.qualcomm.com>
Newsgroups linux.kernel
Subject Re: [PATCH] net: wireless: ath: ath10k: remove unnecessary code
Date 2017-05-09 14:30 +0200
Message-ID <tFcr7-1Fu-7@gated-at.bofh.it> (permalink)
References <tF4WB-54x-5@gated-at.bofh.it> <tF62m-5K4-15@gated-at.bofh.it> <tFc7M-1x6-21@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Arend Van Spriel <arend.vanspriel@broadcom.com> writes:

> On 9-5-2017 7:33, Kalle Valo wrote:
>> "Gustavo A. R. Silva" <garsilva@embeddedor.com> writes:
>> 
>>> The name of an array used by itself will always return the array's address.
>>> So these tests will always evaluate as false and therefore the _return_
>>> will never be executed.
>>>
>>> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
>> 
>> I don't understand the commit log, especially what does "The name of an
>> array used by itself" mean?
>
> The array fields in struct wmi_start_scan_arg that are checked here are
> fixed size arrays so they can never be NULL.
>
> Maybe that helps rephrasing this commit message.

Much much better, thanks!

-- 
Kalle Valo

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] net: wireless: ath: ath10k: remove unnecessary code "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-05-09 06:30 +0200
  Re: [PATCH] net: wireless: ath: ath10k: remove unnecessary code Kalle Valo <kvalo@qca.qualcomm.com> - 2017-05-09 07:40 +0200
    Re: [PATCH] net: wireless: ath: ath10k: remove unnecessary code Arend Van Spriel <arend.vanspriel@broadcom.com> - 2017-05-09 14:10 +0200
      Re: [PATCH] net: wireless: ath: ath10k: remove unnecessary code Kalle Valo <kvalo@qca.qualcomm.com> - 2017-05-09 14:30 +0200
      Re: [PATCH] net: wireless: ath: ath10k: remove unnecessary code "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-05-09 15:00 +0200
    Re: [PATCH] net: wireless: ath: ath10k: remove unnecessary code "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-05-09 14:30 +0200

csiph-web