Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1639904
| From | Daniel Bristot de Oliveira <bristot@redhat.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH RFC] sched/deadline: Use the revised wakeup rule for suspending constrained dl tasks |
| Date | 2017-05-11 19:10 +0200 |
| Message-ID | <tFZLc-KD-15@gated-at.bofh.it> (permalink) |
| References | <tzNWq-ba-7@gated-at.bofh.it> <tDpLQ-4yP-11@gated-at.bofh.it> <tDpVw-4CY-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 05/04/2017 04:26 PM, Peter Zijlstra wrote:
> On Thu, May 04, 2017 at 04:17:21PM +0200, Peter Zijlstra wrote:
>> We use two difference CBS rules:
>>
>> 1) the original CBS rule for implicit deadline tasks;
>> 2) the revised CBS rule for constrained deadline tasks.
>>> @@ -500,6 +550,14 @@ static void update_dl_entity(struct sched_dl_entity *dl_se,
>>>
>>> if (dl_time_before(dl_se->deadline, rq_clock(rq)) ||
>>> dl_entity_overflow(dl_se, pi_se, rq_clock(rq))) {
>>> +
>>> + if (unlikely(dl_is_constrained(dl_se) &&
>>> + !dl_time_before(dl_se->deadline, rq_clock(rq)) &&
>>> + !dl_se->dl_boosted)){
>>> + update_dl_revised_wakeup(dl_se, rq);
>>> + return;
>>> + }
>>> +
>>> dl_se->deadline = rq_clock(rq) + pi_se->dl_deadline;
>>> dl_se->runtime = pi_se->dl_runtime;
>>> }
> That comment above does not match the code. We can still use the
> original CBS rule for constrained tasks.
>
> We only use the revised CBS rule when the constrained task hasn't missed
> its deadline yet.
Correct. I will improve the explanation.
Thank you very much for all comments :-)
-- Daniel
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH RFC] sched/deadline: Use the revised wakeup rule for suspending constrained dl tasks Peter Zijlstra <peterz@infradead.org> - 2017-05-04 16:20 +0200
Re: [PATCH RFC] sched/deadline: Use the revised wakeup rule for suspending constrained dl tasks Peter Zijlstra <peterz@infradead.org> - 2017-05-04 16:30 +0200
Re: [PATCH RFC] sched/deadline: Use the revised wakeup rule for suspending constrained dl tasks Daniel Bristot de Oliveira <bristot@redhat.com> - 2017-05-11 19:10 +0200
Re: [PATCH RFC] sched/deadline: Use the revised wakeup rule for suspending constrained dl tasks Peter Zijlstra <peterz@infradead.org> - 2017-05-04 17:30 +0200
Re: [PATCH RFC] sched/deadline: Use the revised wakeup rule for suspending constrained dl tasks Daniel Bristot de Oliveira <bristot@redhat.com> - 2017-05-11 19:10 +0200
Re: [PATCH RFC] sched/deadline: Use the revised wakeup rule for suspending constrained dl tasks Daniel Bristot de Oliveira <bristot@redhat.com> - 2017-05-11 19:10 +0200
csiph-web