Re: [PATCH] netxen_nic: set rcode to the return status from the call to netxen_issue_cmd

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] netxen_nic: set rcode to the return status from the call to netxen_issue_cmd
Date	2017-05-11 18:20 +0200
Message-ID	<tFYYO-ax-29@gated-at.bofh.it> (permalink)
References	<tFgbn-4bu-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Colin King <colin.king@canonical.com>
Date: Tue,  9 May 2017 17:19:42 +0100

> From: Colin Ian King <colin.king@canonical.com>
> 
> Currently rcode is being initialized to NX_RCODE_SUCCESS and later it
> is checked to see if it is not NX_RCODE_SUCCESS which is never true. It
> appears that there is an unintentional missing assignment of rcode from
> the return of the call to netxen_issue_cmd() that was dropped in
> an earlier fix, so add it in.
> 
> Detected by CoverityScan, CID#401900 ("Logically dead code")
> 
> Fixes: 2dcd5d95ad6b2 ("netxen_nic: fix cdrp race condition")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Applied.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] netxen_nic: set rcode to the return status from the call to netxen_issue_cmd Colin King <colin.king@canonical.com> - 2017-05-09 18:30 +0200
  Re: [PATCH] netxen_nic: set rcode to the return status from the  call to netxen_issue_cmd David Miller <davem@davemloft.net> - 2017-05-11 18:20 +0200

csiph-web