Re: [PATCH v7 4/5] i2c: aspeed: added driver for Aspeed I2C

From	Benjamin Herrenschmidt <benh@kernel.crashing.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v7 4/5] i2c: aspeed: added driver for Aspeed I2C
Date	2017-05-09 09:20 +0200
Message-ID	<tF7B8-6TD-15@gated-at.bofh.it> (permalink)
References	<tzQUi-21B-7@gated-at.bofh.it> <tzQUi-21B-15@gated-at.bofh.it> <tF34t-3Uj-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, 2017-05-08 at 16:28 -0700, Brendan Higgins wrote:
> 
> I am curious what everyone thinks about this. It seemed that, earlier
> on, people did not like me disabling multi-master mode, but I think
> that it would make bus recovery not work as well. Given that, I think
> it makes the most sense to provide a device tree option either to
> enable multi-master support or disable it. Thoughts?

I think we probably want to keep it enabled yes. Another reason is that
SMBus notifications are in effect a type of multi-master (well slave
really), and we should really add support for them even when the slave
is not enabled.

We are hitting some PMbus devices that apparently can't be prevented
from sending those and that's causing issues.

Cheers,
Ben.

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v7 4/5] i2c: aspeed: added driver for Aspeed I2C Benjamin Herrenschmidt <benh@kernel.crashing.org> - 2017-05-09 09:20 +0200

csiph-web